Bug 393023

Summary:	callgrind_control risks using the wrong vgdb
Product:	[Developer tools] valgrind	Reporter:	John Reiser <jreiser>
Component:	callgrind	Assignee:	Josef Weidendorfer <josef.weidendorfer>
Status:	RESOLVED FIXED
Severity:	normal	CC:	philippe.waroquiers
Priority:	NOR
Version First Reported In:	3.13 SVN
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description John Reiser 2018-04-11 21:15:24 UTC

The perl script 'callgrind_control' sub-invokes 'vgdb' free in $PATH:
  open LIST, "vgdb $vgdbPrefixOption -l|";
  open RESULT, "vgdb $vgdbPrefixOption --pid=$pid $vgdbCommand|";
which might invoke a mismatching vgdb (stale version in abandoned directory, etc.)

It would be safer to look for vgdb first in the installation tree of valgrind tools, typically the same tree in which the running 'callgrind_control' resides.

[Low priority, but the problem has happened.]

Comment 1 Philippe Waroquiers 2018-04-15 10:45:34 UTC

Fix committed as 532ed8a48b72231f424dd0b421cceb91d601389a

Thanks for the bug report