Summary: | KIO Thumb::URI not following freedesktop thumbnail specifications, leading to incompatibilities with other DEs | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Glut <glutbugreports> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ewilhelm, glutbugreports, kde, kdelibs-bugs, Laurent.Rineau__kde, me, nate, null |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 5.44.0 | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio/371e523f5d7ee0e37934135db6499eff3b976162 | Version Fixed In: |
Description
Glut
2018-04-11 17:33:00 UTC
Sorry, the Platform information meant to read: Kubuntu 18.04 development branch, updated as of 2018-04-11 Looks like we just need to not percent-encode the paths? I wish all bug reports were that detailed. If you can test that would be great. https://phabricator.kde.org/D12133 @Nate, David: Thank you for the lightning-fast response, guys! Glad I could do my part in reporting this :). I don't have the required dev environment set up to compile and test this from source, but I'm looking forward to giving the fix a try once it lands in a package. Git commit 371e523f5d7ee0e37934135db6499eff3b976162 by David Edmundson. Committed on 12/04/2018 at 20:35. Pushed by davidedmundson into branch 'master'. Correctly encode URL of thumbnails Summary: As per the amazingly detailed bug report, the spec says URLs should be percent encoded. The main knock-on effect is we get a different hash value for our preview file and we duplicate thumbnails if a user uses a GNOME app. Test Plan: Logged out and back in Copied jpeg to a file with spaces opened dolphin Found relevant cache file in ~/.cache/thumbnails/normal based on timestamp exiftool showed the correct URI. Thumb URI : file:///tmp/with%20spaces.jpg I assume the hash is now "correct" but I don't have a way to check Reviewers: ngraham Reviewed By: ngraham Subscribers: ngraham, #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D12133 M +4 -4 src/widgets/previewjob.cpp https://commits.kde.org/kio/371e523f5d7ee0e37934135db6499eff3b976162 *** Bug 105332 has been marked as a duplicate of this bug. *** *** Bug 111801 has been marked as a duplicate of this bug. *** |