Summary: | [wayland] - Blur effect crashes Latte on exit | ||
---|---|---|---|
Product: | [Plasma] lattedock | Reporter: | Michail Vourlakos <mvourlakos> |
Component: | application | Assignee: | Michail Vourlakos <mvourlakos> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Michail Vourlakos
2018-04-08 20:15:11 UTC
Note: I mean under Wayland, for X11 everything works just fine... Are you sure you setup everything correctly? I consider it unlikely that this works for Plasma but crashes for Latte. Please compare the setup sequence to usage in plasma. From the backtrace it looks like you setup blur too early before Qt created the Wayland window. Please in general: first question your own implementation before creating bug reports. If you have questions concerning API usage please ask on the mailing list instead of bug reports. It doesn't scale if I have to handle all latte questions. Git commit 745b9ea07554cda9d71d10e6b937d15a90da4dde by Michail Vourlakos. Committed on 09/04/2018 at 08:38. Pushed by mvourlakos into branch 'master'. dont apply too early blur effect dont delay the corona destruction under wayland because that creates a crash with kwin effects M +3 -3 app/dock/dockview.cpp M +10 -5 app/dockcorona.cpp https://commits.kde.org/latte-dock/745b9ea07554cda9d71d10e6b937d15a90da4dde (In reply to Martin Flöser from comment #2) > Are you sure you setup everything correctly? I consider it unlikely that > this works for Plasma but crashes for Latte. Please compare the setup > sequence to usage in plasma. From the backtrace it looks like you setup blur > too early before Qt created the Wayland window. I found it, even though it was something a little different. Latte in order to slide-out its docks/panels during exit it was delaying the corona destruction which is the parent of "KWayland::Client::PlasmaShell". It was using the following code in corona destruction: QTimer::singleShot(400, [this]() { m_quitTimedEnded = true; }); while (!m_quitTimedEnded) { QGuiApplication::processEvents(QEventLoop::AllEvents, 50); } -------- by blocking this code for wayland crash disappeared. > Please in general: first question your own implementation before creating > bug reports. If you have questions concerning API usage please ask on the > mailing list instead of bug reports. It doesn't scale if I have to handle > all latte questions. of course. I just wanted to keep track and the mailing list isnt that helpful. I think the best in the future is to file them under latte-dock product and point to mailing lists if someone wants to help or explain me. thanks a lot for your efforts |