Summary: | Dolphin git plugin crash. | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Tony <jodr666> |
Component: | plugins: git | Assignee: | Sebastian Dörner <sebastian> |
Status: | RESOLVED DOWNSTREAM | ||
Severity: | crash | CC: | dolphin-bugs-null, elvis.angelaccio, jodr666 |
Priority: | NOR | Keywords: | drkonqi |
Version: | 17.12.2 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
Installed
New crash information added by DrKonqi Valgrind log |
Description
Tony
2018-04-02 07:59:55 UTC
If you can reproduce the crash, please install debug symbols for the dolphin-plugins package. See https://community.kde.org/Dolphin/FAQ/Crashes Created attachment 111838 [details] Installed (In reply to Elvis Angelaccio from comment #1) > If you can reproduce the crash, please install debug symbols for the > dolphin-plugins package. See https://community.kde.org/Dolphin/FAQ/Crashes They are installed..... ....Unless for some reason on Fedora you need the debugsource as well. No idea about Fedora packaging, but #16 0x00007f1ff49a4ebc in PushDialog::PushDialog(QWidget*) () from /usr/lib64/qt5/plugins/fileviewgitplugin.so means that this plugin (which should be part of dolphin-plugins) doesn't have debug symbols available. Created attachment 112801 [details] New crash information added by DrKonqi dolphin (18.07.70) using Qt 5.11.0 - What I was doing when the application crashed: I hit "Git Push" while inside a clone repo from https://github.com/RobertBeckebans/RBDOOM-3-BFG. The cloned repo was copied from a Fedora 27 system were i experience the same issue, but could not reproduce easily. Here is 100% sure crash if you hit "Git push". -- Backtrace (Reduced): #6 0x00007efc2b5d89cd in QVariant::QVariant(QString const&) () from /usr/lib64/libQt5Core.so.5 #7 0x00007efc2c6da2a5 in QComboBox::setCurrentText(QString const&) () from /usr/lib64/libQt5Widgets.so.5 #8 0x00007efbfcf36f9c in PushDialog::PushDialog (this=0x7fff144016e0, parent=<optimized out>) at /usr/src/debug/dolphin-plugins-18.07.70git.20180430T053112~d69ced4-8.2.x86_64/git/pushdialog.cpp:105 #9 0x00007efbfcf2bc96 in FileViewGitPlugin::push (this=0x55f416d625a0) at /usr/src/debug/dolphin-plugins-18.07.70git.20180430T053112~d69ced4-8.2.x86_64/git/fileviewgitplugin.cpp:630 [...] #11 0x00007efc2c5d2582 in QAction::triggered(bool) () from /usr/lib64/libQt5Widgets.so.5 (In reply to Tony from comment #5) > Created attachment 112801 [details] > New crash information added by DrKonqi > > dolphin (18.07.70) using Qt 5.11.0 > > - What I was doing when the application crashed: > > I hit "Git Push" while inside a clone repo from > https://github.com/RobertBeckebans/RBDOOM-3-BFG. > > The cloned repo was copied from a Fedora 27 system were i experience the > same issue, but could not reproduce easily. Here is 100% sure crash if you > hit "Git push". > > -- Backtrace (Reduced): > #6 0x00007efc2b5d89cd in QVariant::QVariant(QString const&) () from > /usr/lib64/libQt5Core.so.5 > #7 0x00007efc2c6da2a5 in QComboBox::setCurrentText(QString const&) () from > /usr/lib64/libQt5Widgets.so.5 > #8 0x00007efbfcf36f9c in PushDialog::PushDialog (this=0x7fff144016e0, > parent=<optimized out>) at > /usr/src/debug/dolphin-plugins-18.07.70git.20180430T053112~d69ced4-8.2. > x86_64/git/pushdialog.cpp:105 > #9 0x00007efbfcf2bc96 in FileViewGitPlugin::push (this=0x55f416d625a0) at > /usr/src/debug/dolphin-plugins-18.07.70git.20180430T053112~d69ced4-8.2. > x86_64/git/fileviewgitplugin.cpp:630 > [...] > #11 0x00007efc2c5d2582 in QAction::triggered(bool) () from > /usr/lib64/libQt5Widgets.so.5 This is on a Opensuse Tumbleweed system. Elvis, is backtrace from comment #5 sufficient to pinpoint the issue? Hmm. Could be that `currentBranchIndex` does not get initialized which would explain why `branches.at(currentBranchIndex)` crashes. A valgrind log would be very helpful, if the crash is 100% reproducible. Created attachment 113380 [details]
Valgrind log
Ok, not what I was thinking of. Could be a bad allocation of memory for the strings containing the branch names. Can you show the output of "git branch -a" in the repository from which you are triggering the crash? I hate myself as i type this, when i typed git branch -a i realized somehow Git was removed from my opensuse system from which i got the valgrind log and the 2nd bracktrace. F me. git branch -a out "after" i re-installed Git: branch_remotes/origin/vkdoom3-merge * master remotes/origin/HEAD -> origin/master remotes/origin/IBL-environment-probes remotes/origin/flash-tools remotes/origin/flash-tools-lua remotes/origin/imgui-tools remotes/origin/master remotes/origin/nvidia-driver-381.65-bugfix remotes/origin/oculus-vr remotes/origin/openvr remotes/origin/vkdoom3-merge Does it still crash after you reinstalled git? (In reply to Elvis Angelaccio from comment #12) > Does it still crash after you reinstalled git? No, while using git push. What I meant was: can you still reproduce the crash when pressing "Git Push", even if have installed git? (In reply to Elvis Angelaccio from comment #14) > What I meant was: can you still reproduce the crash when pressing "Git > Push", even if have installed git? No, on my opensuse system i haven't seen any crashes with "git push" after installing git. Thanks, I'll close this report for now then. |