Bug 392559

Summary: Playback no longer works with isolate layer
Product: [Applications] krita Reporter: Bollebib <kwadraatnope>
Component: AnimationAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version: 4.0   
Target Milestone: ---   
Platform: Other   
OS: Microsoft Windows   
Latest Commit: https://commits.kde.org/krita/4a1b6717835a38a371afc799f9390e5e7e58d310 Version Fixed In:
Sentry Crash Report:

Description Bollebib 2018-03-31 12:25:04 UTC 
I use isolate layer very often


in 3.3 i could use isolate layer and playback the contents,it would only play the isolated layer.


in current 4.0 this is broken. It ALWAYS shows the normal viex.
Comment 1 Dmitry Kazakov 2018-04-05 07:01:41 UTC 
Hi, Bollebib!

I guess this bug was a consequence of the save/autosave bug. I cannot reproduce it anymore. If you happen to see it on the nightly builds, please reopen the bug :)

*** This bug has been marked as a duplicate of bug 392233 ***
Comment 2 Bollebib 2018-04-14 19:22:44 UTC 
This still happens,isolate layer doesnt work well with playback,it flickers.
Comment 3 Dmitry Kazakov 2018-04-15 11:20:50 UTC 
If it flickers, it might be that some of the cached frames still keep old contents...
Comment 4 Dmitry Kazakov 2018-05-04 12:17:05 UTC 
Git commit 739536ba847b3b179463e1301833b763a6d0327f by Dmitry Kazakov.
Committed on 04/05/2018 at 12:16.
Pushed by dkazakov into branch 'master'.

Fix playback in isolated mode

Since we copy the image into multiple threads while doing
animation cache generation, we should also copy the isolated
root node parameter.

M  +12   -3    libs/image/kis_image.cc

https://commits.kde.org/krita/739536ba847b3b179463e1301833b763a6d0327f
Comment 5 Halla Rempt 2018-05-04 14:01:09 UTC 
Git commit 4a1b6717835a38a371afc799f9390e5e7e58d310 by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 04/05/2018 at 12:55.
Pushed by rempt into branch 'krita/4.0'.

Fix playback in isolated mode

Since we copy the image into multiple threads while doing
animation cache generation, we should also copy the isolated
root node parameter.
(cherry picked from commit 739536ba847b3b179463e1301833b763a6d0327f)

M  +12   -3    libs/image/kis_image.cc

https://commits.kde.org/krita/4a1b6717835a38a371afc799f9390e5e7e58d310