| Summary: | holidays for India (in_en-gb) not complete | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kholidays | Reporter: | sk.griffinix |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | sk.griffinix, winter |
| Priority: | NOR | ||
| Version: | 5.44.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kholidays/c84e4d9d1724e4d49bbb2ae8db32c47a4c098ed7 | Version Fixed In: | 5.45 |
| Attachments: |
holiday file for india
holiday file for india (spellings corrected) |
||
|
Description
sk.griffinix
2018-03-29 20:18:49 UTC
Do you want to submit a patch ? The code can be found in the kholidays repository (https://cgit.kde.org/kholidays.git/) The file format is explained in the file-format.txt file and the holidays files are in the plan2/ folder. I have little experience in programming but i will try Thanks ! This might be more difficult than anticipated. The holidays are based on hindu calendar, which varies from the georgian calendar. The indiannational calender that is supported also corresponds to georgian calendar. The closest one to hindu calendar is the hebrew calendar, but its not exactly corresponding. The best bet would be to add support for hindu calendar. Alternatively, if the dates of holidays in hindu calendar can be compared to hebrew one, and if they are found to match for reasonable number of years, then the holiday file can be created with dates referred with the hebrew calendar. However i lack the resources to compare them. If someone can point me, i would be prepared to verify I'm afraid you're right, the lunar calendar doesn't seem to be supported. A solution could be specifying the days for each year (starting with 2018 and for a couple years). That's what was done eg. in the indonesian file (holiday_id_id) Created attachment 111742 [details]
holiday file for india
How is the file added to frameworks? How can i modify the one on my computer? relegious -> religious Oops I will change no earlier than 5:00:00 UTC Created attachment 111748 [details]
holiday file for india (spellings corrected)
Git commit c84e4d9d1724e4d49bbb2ae8db32c47a4c098ed7 by Allen Winter. Committed on 02/04/2018 at 17:29. Pushed by winterz into branch 'master'. holidays/plan2/holiday_in_en-gb - update holiday file for India Thank you for the patch. M +136 -29 holidays/plan2/holiday_in_en-gb https://commits.kde.org/kholidays/c84e4d9d1724e4d49bbb2ae8db32c47a4c098ed7 I wonder how/if to backport this since kholidays was previously not a framework? |