| Summary: | [Create new document dialogue] Put the default button on the bottom-right corner. | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tyson Tan <tysontanx> |
| Component: | Usability | Assignee: | Scott Petrovic <scottpetrovic> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla |
| Priority: | NOR | ||
| Version First Reported In: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Examples of default button on dialogue's bottom-right corner | ||
Scott, I'm not sure why you changed the order of the buttons. In fact, we shouldn't manage the order of ok/cancel/etc ourselves but let Qt handle that in all cases, because it follows the OS/desktop defaults. This is the class we should be using, if we're not using KoDialog which does this as well: http://doc.qt.io/qt-5/qdialogbuttonbox.html It might be a good project to identify all the places where we're hardcoding the dialog standard button order... Scott fixed this. Thank you! |
Created attachment 111717 [details] Examples of default button on dialogue's bottom-right corner krita-4.1.0-pre-alpha-ddc6882-x86_64.appimage Recently I noticed the default button position has been changed -- it causes a lot of mis-clicks and I think we should revert such change. There is a reason why the default "do" button of these type of dialogues is often placed on the extreme of something -- we don't need to look and think about it -- we just go after the one of the end of the row! We open such dialogues "to do something", not so often "to cancel it". Human brain loves shortcuts. In the attachment I include some other dialogue examples for my argument. This suggestion also applies for all other dialogues with similar purposes.