Bug 392445

Summary:	Falkon doesn't recognize spaces encoded as "%20" in URL
Product:	[Applications] Falkon	Reporter:	kde
Component:	general	Assignee:	David Rosca <nowrep>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugs.kde.org, jr, private2.6.3
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	https://commits.kde.org/falkon/2f6cd7a559b51abc0bba738c5fefb5b1fba72c3a	Version Fixed/Implemented In:	3.0.1
Sentry Crash Report:

Description kde 2018-03-28 09:50:05 UTC

When entering a URL that contains spaces encodes as "%20", Falkon will not convert those to spaces but pass the string to the search engine verbatim.

example:

http://www.example.com/my%20beautiful%20page

Comment 1 David Rosca 2018-03-28 09:52:29 UTC

As a workaround, you can use "Shift+Enter" to force loading any url (even invalid) you type in locationbar.

Comment 2 kde 2018-03-28 10:08:00 UTC

Thanks. And I've found that it will load the URL if it's a link, like above, but NOT if you enter it directly and load with Enter.

Comment 3 David Rosca 2018-03-28 16:51:58 UTC

*** Bug 392444 has been marked as a duplicate of this bug. ***

Comment 4 David Rosca 2018-03-28 16:58:37 UTC

Git commit 2f6cd7a559b51abc0bba738c5fefb5b1fba72c3a by David Rosca.
Committed on 28/03/2018 at 16:54.
Pushed by drosca into branch 'Falkon/3.0'.

LocationBar: Fix resolving correct LoadAction when url contains %20
FIXED-IN: 3.0.1

M  +13   -0    autotests/locationbartest.cpp
M  +1    -0    autotests/locationbartest.h
M  +2    -2    src/lib/navigation/locationbar.cpp

https://commits.kde.org/falkon/2f6cd7a559b51abc0bba738c5fefb5b1fba72c3a

Comment 5 kde 2018-04-09 13:04:53 UTC

Does this fix other URL encodings as well?
I've found that Falkon 3.0.0 displays links such as
https://example.com/files/per%25cent.jpg correctly and shows the correct file name in the title ("per%cent.jpg"), but when trying to save the file it will propose "per�nt" as name.

Comment 6 The_assassin 2018-04-09 13:20:05 UTC

>...but when trying to save the file it will propose "per�nt" as name.
This is due to your LOCALE settings.

Comment 7 kde 2018-04-09 13:21:48 UTC

Why does it show the correct name in the title then?

Comment 8 The_assassin 2018-04-09 13:25:15 UTC

Because it uses internal character encoding there.

Comment 9 kde 2018-04-09 13:30:38 UTC

I can see the correct name "per%cent.jpg" in Dolphin too, just when saving it from Falkon it gets mangled. Is it perhaps a Frameworks problem?

Comment 10 kde 2018-04-09 13:42:37 UTC

I've done a little testing, and it handles all other special characters and umlauts. Percent signs will break it however.

Comment 11 The_assassin 2018-04-09 13:57:08 UTC

I do not agree that "per%cent.jpg" is the correct name, 
it should be "per cent.jpg"
What happens if you start Falkon from terminal as follow:

LANG=en_US.utf8 falkon

Comment 12 kde 2018-04-09 14:07:34 UTC

Same issue.
The name should *not* be "per cent.jpg" because I'm not talking about spaces encoded as %20, but the percent sign itself encoded as %25

Comment 13 The_assassin 2018-04-09 14:53:28 UTC

>...I'm not talking about spaces encoded as %20, but the percent sign itself encoded as %25
Aha,sorry!
Well, I just tested with this: https://yadi.sk/i/KEx7vR7y3UFETC
The pucture name is "Capture%du%2018-04-09%17:04:06.png", but in save dialog it becomes "Capture� 18-04-09:04:06.png", so perhaps something's really wrong.

Comment 14 Erik Quaeghebeur 2018-05-14 06:47:02 UTC

*** Bug 394217 has been marked as a duplicate of this bug. ***

Comment 15 kde 2018-05-18 10:11:05 UTC

I think it's not quite resolved yet as the file saving problem still exists.

Comment 16 David Rosca 2018-05-18 14:05:55 UTC

The bug reported in first comment is fixed. Please don't reopen bugs, instead open new one.