Bug 392282

Summary:	No x2 splash screen pixmap for hidpi screens
Product:	[Applications] krita	Reporter:	Isaac Zuniga <isaaczuniga>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	amy, halla
Priority:	NOR
Version:	4.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://commits.kde.org/krita/cf7263c8bcf0463115c76c4e477d0dc4a900b6b4	Version Fixed In:
Attachments:	Splash screen when Hi-DPI is disabled. Splash screen when Hi-DPI is enabled.

Description Isaac Zuniga 2018-03-24 19:43:03 UTC

Created attachment 111615 [details]
Splash screen when Hi-DPI is disabled.

I didn't report this in earlier versions of Krita, even though I could tell it was being stretched out, because I wasn't sure if the original image was really that small or not. Knowing that Tyson Tan's image is much larger than the smaller version of the splash screen (When Hi-DPI support is unchecked), I knew this is something that should be ironed out in a future release.

https://drive.google.com/file/d/1Vi_ocO2CZL-OEXzIov9txkrJFrJ36hv1/view?usp=sharing

The image looks pixelated, along with the Krita logo and the status text. I wonder if this falls under a 4K scaling issue similar to why the canvas reports 100% zoom when the actual canvas is at 200%? A QT issue?

Comment 1 Isaac Zuniga 2018-03-24 19:43:43 UTC

Created attachment 111616 [details]
Splash screen when Hi-DPI is enabled.

Comment 2 Halla Rempt 2018-03-28 12:28:11 UTC

See http://doc.qt.io/qt-5/qpainter.html#drawing-high-resolution-versions-of-pixmaps-and-images

Comment 3 Isaac Zuniga 2018-03-28 19:58:07 UTC

(In reply to Boudewijn Rempt from comment #2)
> See
> http://doc.qt.io/qt-5/qpainter.html#drawing-high-resolution-versions-of-
> pixmaps-and-images

I read it, but is this something that can be fixed, or is this something that is going to exist with no possible re-coding solution?

I'm just bringing this to attention again because it just looks weird and I wasn't sure what the specifics of the circumstance was.

Comment 4 Halla Rempt 2018-04-28 11:04:15 UTC

It's something we need to work on, and I added the link just to make sure we would know where to look when we finally get down to it. There's over 300 open bugs, though...

Comment 5 Halla Rempt 2018-05-10 14:41:21 UTC

Git commit 95b62e5041ccdb12c435275be2e73a171deb1fa1 by Boudewijn Rempt.
Committed on 10/05/2018 at 14:40.
Pushed by rempt into branch 'master'.

Add updated splash and hidpi splash

M  +82242 -78272 krita/data/splash/splash_holidays.xpm
A  +195171 -0    krita/data/splash/splash_holidays_x2.xpm
M  +47578 -49467 krita/data/splash/splash_screen.xpm
A  +76990 -0    krita/data/splash/splash_screen_x2.xpm
M  +4    -2    krita/main.cc
M  +2    -1    libs/ui/dialogs/kis_about_application.cpp
M  +6    -1    libs/ui/kis_splash_screen.cpp
M  +1    -1    libs/ui/kis_splash_screen.h

https://commits.kde.org/krita/95b62e5041ccdb12c435275be2e73a171deb1fa1

Comment 6 amyspark 2018-05-11 01:24:07 UTC

I compiled 95b62e5041ccdb12c435275be2e73a171deb1fa1 on MacOS Sierra 10.12.6 and can confirm both issues are fixed.

Comment 7 Halla Rempt 2018-05-12 08:57:41 UTC

Git commit cf7263c8bcf0463115c76c4e477d0dc4a900b6b4 by Boudewijn Rempt.
Committed on 12/05/2018 at 08:27.
Pushed by rempt into tag 'v3.0.4'.

Add updated splash and hidpi splash
(cherry picked from commit 95b62e5041ccdb12c435275be2e73a171deb1fa1)

M  +82242 -78272 krita/data/splash/splash_holidays.xpm
A  +195171 -0    krita/data/splash/splash_holidays_x2.xpm
M  +47578 -49467 krita/data/splash/splash_screen.xpm
A  +76990 -0    krita/data/splash/splash_screen_x2.xpm
M  +4    -2    krita/main.cc
M  +2    -1    libs/ui/dialogs/kis_about_application.cpp
M  +6    -1    libs/ui/kis_splash_screen.cpp
M  +1    -1    libs/ui/kis_splash_screen.h

https://commits.kde.org/krita/cf7263c8bcf0463115c76c4e477d0dc4a900b6b4