Bug 392135

Summary: Reordering windows in group popup also reorder top level windows
Product: [Plasma] plasmashell Reporter: ariasuni <aria>
Component: Task Manager and Icons-Only Task Manager widgetsAssignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: normal CC: notuxius, plasma-bugs-null
Priority: NOR    
Version First Reported In: master   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description ariasuni 2018-03-21 12:40:25 UTC 
## Reproduce the bug:

For example if I have:

- App 1
- App 2
- App 3
- App 4
  - App 4 – Win 1
  - App 4 – Win 2
- App 5

If I try to reorder the windows of app 4, I get this result:

- App 2
- App 1
- App 3
- App 4
  - App 4 – Win 2
  - App 4 – Win 1
- App 5

As if App 1 was linked to «App 4 – Win 1» and App 2 to «App 4 – Win 2».

The get the same result if I try to exchange App 1 and App 2 when the group popup is visible, except that it’s laggy, especially when reordering several times in a row.


## Excepted behavior

- When reordering windows inside a group popup, it should not exchange top-level windows.
- When reordering top-level windows when a group popup is visible, close the popup on drag start (the bug is not triggered when popup group is not visible, and closing a popup when doing something else is a more common behavior).


## Code investigation

The problem seems to lie around here[1]. As the function does the excepted change, I guess the side effect is a bug in the model, but I couldn’t find where the TasksModel or move function is defined.

[1]: <https://phabricator.kde.org/source/plasma-desktop/browse/master/applets/taskmanager/package/contents/ui/MouseHandler.qml;8af970fd49f3ca33450cf3ccd81856694a0dc752$111>
Comment 1 ariasuni 2018-08-28 08:01:49 UTC 
I still have this problem with Plasma 5.13.4 and KDE Frameworks 5.49.0.
Comment 2 Eike Hein 2018-09-16 08:47:59 UTC 
Can reproduce, working on fix.
Comment 3 Eike Hein 2018-09-16 09:33:34 UTC 
Patch under review: https://phabricator.kde.org/D15550
Comment 4 Alexander Mentyu 2018-09-22 11:25:16 UTC 
Can reproduce both in Wayland and X11
Netrunner Rolling
KDE 5.13.5
Frameworks 5.50.0
Qt 5.11.2
Comment 5 Eike Hein 2018-09-24 06:48:35 UTC 
The above patch got landed, I forgot to add BUG: to the commit msg.
Comment 6 ariasuni 2018-09-24 10:06:43 UTC 
Thank you so much, this issue was annoying me for a long time ^-^