Bug 392068

Summary: Parts of text outside the bounding box are retraced on the canvas
Product: [Applications] krita Reporter: Safa Alfulaij <safa1996alfulaij>
Component: Tool/TextAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: halla, kalia24
Priority: NOR    
Version: 4.0.0-beta.1   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:
Attachments: The drawing issue in the canvas

Description Safa Alfulaij 2018-03-19 15:58:05 UTC
Created attachment 111511 [details]
The drawing issue in the canvas

If the text got out of the bounding box (not sure about the reason), that part is retraced while dragging the text around. Check attached screenvideo.

I've used Noto Nastaliq Urdu and the text:
تجربة جميلة
Comment 1 Halla Rempt 2018-03-20 07:11:18 UTC
Hi Safa,

I have seen the same issue happen with western fonts that painted a bit outside the actual bounding box, so I'll confirm the bug and ask Dmitry to look into it.
Comment 2 Dmitry Kazakov 2018-03-21 16:32:19 UTC
Yes, I can confirm, the bug is present with this specific font
Comment 3 Dmitry Kazakov 2018-03-21 16:42:18 UTC
Git commit 8d3c46632d42ab5b59a7e9b68e498e3496d2076a by Dmitry Kazakov.
Committed on 21/03/2018 at 16:41.
Pushed by dkazakov into branch 'master'.

Add one more workaround on glyph bounds calculation

The left side of the glyph run should also be adjusted
to handle all the bearings.

M  +12   -4    libs/flake/text/KoSvgTextShape.cpp

https://commits.kde.org/krita/8d3c46632d42ab5b59a7e9b68e498e3496d2076a
Comment 4 Halla Rempt 2018-03-21 19:11:47 UTC
Git commit ba1dfdc97435cf2dd447a5827cb4537d2c650176 by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 21/03/2018 at 19:11.
Pushed by rempt into branch 'krita/4.0'.

Add one more workaround on glyph bounds calculation

The left side of the glyph run should also be adjusted
to handle all the bearings.
(cherry picked from commit 8d3c46632d42ab5b59a7e9b68e498e3496d2076a)

M  +12   -4    libs/flake/text/KoSvgTextShape.cpp

https://commits.kde.org/krita/ba1dfdc97435cf2dd447a5827cb4537d2c650176
Comment 5 Dmitry Kazakov 2018-04-02 14:28:00 UTC
*** Bug 389524 has been marked as a duplicate of this bug. ***