Summary: | New text tool doesn't use the SVG property for RTL text | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Safa Alfulaij <safa1996alfulaij> |
Component: | Tool/Text | Assignee: | Dmitry Kazakov <dimula73> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | griffinvalley, halla |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/krita/a3ca8183306a6436dbfb6d622c6f65241bb7cf39 | Version Fixed In: | |
Attachments: |
Krita displaying Arabic text and the exclamation mark is on the right instead of left
Krita displaying Arabic and English texts, and the exclamation mark is on the right side of the Arabic sentence instead of left |
Description
Safa Alfulaij
2018-03-19 15:21:07 UTC
Created attachment 111508 [details]
Krita displaying Arabic and English texts, and the exclamation mark is on the right side of the Arabic sentence instead of left
Thanks for reporting. I suspect the property just isn't converted at all when doing from qdocument to svg. Dmitry, can you take a look? Git commit a7c8affee3437ea80c27ec6f3670044ce788b250 by Dmitry Kazakov. Committed on 21/03/2018 at 19:27. Pushed by dkazakov into branch 'master'. Implement automatic 'rtl' tag for arabic text pasted in the text editor Thanks samirosman for his consultations on the topic of Arabic languages! :) M +26 -2 libs/flake/text/KoSvgTextShapeMarkupConverter.cpp https://commits.kde.org/krita/a7c8affee3437ea80c27ec6f3670044ce788b250 Thanks a lot Dmitry! I was wondering why we don't use just http://doc.qt.io/qt-5/qstring.html#isRightToLeft... Or even http://doc.qt.io/qt-5/qtextblock.html#textDirection :) Git commit a3ca8183306a6436dbfb6d622c6f65241bb7cf39 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 03/04/2018 at 11:15. Pushed by rempt into branch 'krita/4.0'. Implement automatic 'rtl' tag for arabic text pasted in the text editor Thanks samirosman for his consultations on the topic of Arabic languages! :) (cherry picked from commit a7c8affee3437ea80c27ec6f3670044ce788b250) M +26 -2 libs/flake/text/KoSvgTextShapeMarkupConverter.cpp https://commits.kde.org/krita/a3ca8183306a6436dbfb6d622c6f65241bb7cf39 I'm still wondering about why not using the direction detect function of QString/QTextBlock, by the way :) A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1859 Git commit 40c638f2ca312a50186698b65622a17579db7b54 by Alvin Wong. Committed on 19/07/2023 at 09:20. Pushed by dkazakov into branch 'master'. flake: Use more reliable way to check RTL from QTextDoc Use the text direction given by QTextBlock directly instead of reinventing the RTL detection. The old check is still kept as a backup, but probably won't be called. M +35 -19 libs/flake/text/KoSvgTextShapeMarkupConverter.cpp https://invent.kde.org/graphics/krita/-/commit/40c638f2ca312a50186698b65622a17579db7b54 |