Bug 392027

Summary:	Crash in SVG Text Tool when input is multiline with a single character per line
Product:	[Applications] krita	Reporter:	Victor Wåhlström <victor.wahlstrom>
Component:	Tool/Text	Assignee:	Victor Wåhlström <victor.wahlstrom>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/krita/d07fcafcd1f1a06436da09ae1a8477b3cb779f27	Version Fixed/Implemented In:
Sentry Crash Report:

Description Victor Wåhlström 2018-03-18 21:34:53 UTC

Repro:

1. Create a new document
2. Activate the new SVG Text Tool
3. Input e.g. "h" <enter> "i"
4. Click Save
5. Observe crash

I can't reproduce this with appimages. It's a 100% out of bounds crash with my local build, and the responsible code is 10 months old.

This should theoretically affect the 4.0 build too, but I haven't tested that.

Comment 1 Victor Wåhlström 2018-03-18 21:39:29 UTC

Git commit bacc6a476ab5daff64a12343775afc3fba2c3d26 by Victor Wåhlström.
Committed on 18/03/2018 at 21:36.
Pushed by victorw into branch 'master'.

Fix potential crash when the last text input line in the SVG Text Tool is a single character

M  +3    -4    libs/flake/text/KoSvgTextShape.cpp

https://commits.kde.org/krita/bacc6a476ab5daff64a12343775afc3fba2c3d26

Comment 2 Dmitry Kazakov 2018-03-19 12:23:21 UTC

Git commit d07fcafcd1f1a06436da09ae1a8477b3cb779f27 by Dmitry Kazakov.
Committed on 19/03/2018 at 12:21.
Pushed by dkazakov into branch 'master'.

Merge branch 'master' of git://anongit.kde.org/krita

# Conflicts:
#	libs/flake/text/KoSvgTextShape.cpp


https://commits.kde.org/krita/d07fcafcd1f1a06436da09ae1a8477b3cb779f27