Bug 391997

Summary:	Two redundant ways to open a folder in a new window from the context menu
Product:	[Applications] dolphin	Reporter:	Nate Graham <nate>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	bugseforuns, elvis.angelaccio
Priority:	NOR
Version First Reported In:	17.12.3
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/dolphin/1859d6455daaa8163fd451e26ffd34cc86738464	Version Fixed/Implemented In:
Sentry Crash Report:

Description Nate Graham 2018-03-18 14:21:30 UTC

Because Dolphin is (logically) registered as a handler for the folder MIME type, it shows up as an option in Dolphin's own "Open With" context menu item.

As a result, the context menu shows two two ways to open a folder in a new Dolphin window:
- Right-click > Open in New Window
- Right-click > Open With > Dolphin

We might consider hiding Dolphin from the "Open With" menu to standardize on the "Open in New Window" and its companion "Open in New Tab" menu items.

Comment 1 Christoph Feck 2018-03-21 01:43:14 UTC

But doesn't the latter spawn a new process?

Comment 2 Nate Graham 2018-03-21 01:48:08 UTC

Both of them do; each Dolphin window is its own process.

Comment 3 Kai Uwe Broulik 2018-03-21 14:54:32 UTC

Git commit b2ff54be3b432abba7b2f3440e978455c75966bb by Kai Uwe Broulik.
Committed on 21/03/2018 at 14:53.
Pushed by broulik into branch 'master'.

[DolphinContextMenu] Fix excluding ourself from Open With menu

The desktop file name changed to org.kde.dolphin a long time ago. To avoid this breaking again, just use qApp->desktopFileName()

Differential Revision: https://phabricator.kde.org/D11540

M  +1    -1    src/dolphincontextmenu.cpp

https://commits.kde.org/dolphin/b2ff54be3b432abba7b2f3440e978455c75966bb

Comment 4 Nate Graham 2018-03-21 15:09:02 UTC

Thanks Kai! Any chance we could land this on the stable branch too, so it gets in for 18.04.0?

Comment 5 Elvis Angelaccio 2018-03-24 10:42:37 UTC

Git commit 1859d6455daaa8163fd451e26ffd34cc86738464 by Elvis Angelaccio, on behalf of Kai Uwe Broulik.
Committed on 24/03/2018 at 10:24.
Pushed by elvisangelaccio into branch 'Applications/18.04'.

[DolphinContextMenu] Fix excluding ourself from Open With menu

The desktop file name changed to org.kde.dolphin a long time ago. To avoid this breaking again, just use qApp->desktopFileName()

Differential Revision: https://phabricator.kde.org/D11540

M  +1    -1    src/dolphincontextmenu.cpp

https://commits.kde.org/dolphin/1859d6455daaa8163fd451e26ffd34cc86738464

Comment 6 Nate Graham 2018-03-24 14:06:13 UTC

Great, thanks!