| Summary: | NETWinInfo::setFullscreenMonitors incorrectly implemented | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kwindowsystem | Reporter: | Martin Flöser <mgraesslin> |
| Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ossman |
| Priority: | NOR | ||
| Version: | 5.44.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| URL: | https://phabricator.kde.org/D11414 | ||
| Latest Commit: | https://commits.kde.org/kwindowsystem/cc5d6fde1abad968a6c54e872a56833db876dca4 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Martin Flöser
2018-03-17 11:02:47 UTC
Patch at: https://phabricator.kde.org/D11414 Git commit cc5d6fde1abad968a6c54e872a56833db876dca4 by Martin Flöser. Committed on 18/03/2018 at 10:45. Pushed by graesslin into branch 'master'. [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS Summary: According to NETWM spec the client "wishing to change this list MUST send a _NET_WM_FULLSCREEN_MONITORS client message to the root window". This was not implemented at all, instead the property was updated. The property must be set by the window manager, or as the spec says: "The Window Manager MUST keep this list updated to reflect the current state of the window." In KWin (as the user of NETWinInfo) this was implemented correctly (see kwin, file netinfo.cpp method WinInfo::changeFullscreenMonitors). Test Plan: New test case added which verifies the client/wm interplay, old and incorrect test case removed Reviewers: #frameworks, #kwin, #plasma Tags: #frameworks Differential Revision: https://phabricator.kde.org/D11414 M +0 -44 autotests/netwininfotestclient.cpp M +85 -0 autotests/netwininfotestwm.cpp M +17 -11 src/platforms/xcb/netwm.cpp https://commits.kde.org/kwindowsystem/cc5d6fde1abad968a6c54e872a56833db876dca4 *** Bug 394246 has been marked as a duplicate of this bug. *** |