Bug 391921

Summary: Pan shifted after canvas rotation with the pop-up palette ring cursor.
Product: [Applications] krita Reporter: mvowada <freebox64>
Component: UsabilityAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: emmetoneill.pdx, gremriel, halla, postrowski5
Priority: NOR    
Version: 4.0.1   
Target Milestone: ---   
Platform: Appimage   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: (Video)

Description mvowada 2018-03-16 10:48:19 UTC
Created attachment 111437 [details]
(Video)

(Krita Version: 4.1.0-pre-alpha (git 97015cd) - Ubuntu 14.04 Unity - Canvas Graphic Acceleration = ON)

The canvas jumps when panning if it has been rotated using the pop-up palette ring cursor. Steps (see video):

    1) canvas > right-click, to show up the popup palette
    2) rotate the canvas using the ring cursor
    3) start panning (middle mouse or left pen)

Actual Results: canvas jumps before panning
Expected Results: pan the canvas
Comment 1 Gremriel 2018-03-16 11:02:03 UTC
I can confirm this on Windows 10 as well. It happens with the first pan, after that there are no more jumps, until you rotate again with the popup palette.
Comment 2 Halla Rempt 2018-03-28 14:36:17 UTC
Dmitry, can you take a look?
Comment 3 Dmitry Kazakov 2018-03-30 13:08:21 UTC
Git commit d3f5e199e0c5a2dca73398a4c517d1331605301d by Dmitry Kazakov.
Committed on 30/03/2018 at 13:08.
Pushed by dkazakov into branch 'master'.

Fix rotation of the canvas using Popup Palette

We should use official canvas controller's methods for rotation
instead of adjusting the coordinates converter manually.

M  +5    -2    libs/ui/kis_popup_palette.cpp

https://commits.kde.org/krita/d3f5e199e0c5a2dca73398a4c517d1331605301d
Comment 4 Halla Rempt 2018-04-03 11:47:42 UTC
Git commit 7e980a9a67052c2894a1b1ee0ab6b8945c6673da by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 03/04/2018 at 11:20.
Pushed by rempt into branch 'krita/4.0'.

Fix rotation of the canvas using Popup Palette

We should use official canvas controller's methods for rotation
instead of adjusting the coordinates converter manually.
(cherry picked from commit d3f5e199e0c5a2dca73398a4c517d1331605301d)

M  +5    -2    libs/ui/kis_popup_palette.cpp

https://commits.kde.org/krita/7e980a9a67052c2894a1b1ee0ab6b8945c6673da
Comment 5 Piotr 2018-04-11 20:46:44 UTC
The bug is still there when resetting rotation to zero using white circle on top of popup palette
Comment 6 Emmet O'Neill 2018-04-12 00:01:37 UTC
I submitted a quick fix to the reset functionality based on Dmitry's prior fix: https://phabricator.kde.org/D12128