Bug 391853

Summary: Makefile.all.am:L247 and @SOLARIS_UNDEF_LARGESOURCE@ being empty
Product: [Developer tools] valgrind Reporter: Дилян Палаузов <dilyan.palauzov>
Component: vexAssignee: Julian Seward <jseward>
Status: RESOLVED FIXED    
Severity: normal CC: mark, pjfloyd
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Дилян Палаузов 2018-03-14 13:56:05 UTC 
Makefile.all.am contains:

244: AM_FLAG_M3264_X86_SOLARIS   = @FLAG_M32@                                                                                                
245: AM_CFLAGS_X86_SOLARIS       = @FLAG_M32@ @PREFERRED_STACK_BOUNDARY_2@ \                                                                 
246:                                $(AM_CFLAGS_BASE) -fomit-frame-pointer \                                                                
247:                                @SOLARIS_UNDEF_LARGESOURCE@                                                                             
248: AM_CFLAGS_PSO_X86_SOLARIS   = @FLAG_M32@ $(AM_CFLAGS_BASE) $(AM_CFLAGS_PSO_BASE)                                                        

On my system this expands to:
VEX/Makefile:
669:AM_FLAG_M3264_X86_SOLARIS = -m32
670:AM_CFLAGS_X86_SOLARIS = -m32 -mpreferred-stack-boundary=2 \
671:                                $(AM_CFLAGS_BASE) -fomit-frame-pointer \
672:                                
673:
674:AM_CFLAGS_PSO_X86_SOLARIS = -m32 $(AM_CFLAGS_BASE) $(AM_CFLAGS_PSO_BASE)

Line 672 consists of four tab characters, and emacs says "Suspicious line 672.  Save anyway (y or n)."

This helps:
diff --git a/Makefile.all.am b/Makefile.all.am
--- a/Makefile.all.am
+++ b/Makefile.all.am
@@ -243,8 +243,7 @@ AM_CCASFLAGS_MIPS64_LINUX  = @FLAG_M64@ -g
 
 AM_FLAG_M3264_X86_SOLARIS   = @FLAG_M32@
 AM_CFLAGS_X86_SOLARIS       = @FLAG_M32@ @PREFERRED_STACK_BOUNDARY_2@ \
-                               $(AM_CFLAGS_BASE) -fomit-frame-pointer \
-                               @SOLARIS_UNDEF_LARGESOURCE@
+                               $(AM_CFLAGS_BASE) -fomit-frame-pointer @SOLARIS_UNDEF_LARGESOURCE@
 AM_CFLAGS_PSO_X86_SOLARIS   = @FLAG_M32@ $(AM_CFLAGS_BASE) $(AM_CFLAGS_PSO_BASE)
 AM_CCASFLAGS_X86_SOLARIS    = @FLAG_M32@ -g -D_ASM
Comment 1 Paul Floyd 2021-01-06 09:59:47 UTC 
A very minor fix. Slightly makes a mess of the line length, but I'd rather be paranoid and not change the order of the arguments.
Comment 2 Mark Wielaard 2021-02-20 14:51:48 UTC 
commit 8caab853a75c020fe546c4ceafb6f7e52326a18a
Author: Paul Floyd <pjfloyd@wanadoo.fr>
Date:   Wed Jan 6 10:57:11 2021 +0100

    Bug 391853 - Makefile.all.am:L247 and @SOLARIS_UNDEF_LARGESOURCE@ being empty