Summary: | Qt text rendering is always being used, leading to text looking a little lighter than necessary | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-qqc2-desktop-style | Reporter: | Nate Graham <nate> |
Component: | general | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, simonandric5 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/qqc2-desktop-style/9a5f7d834f86f57e88c3993fbcf4c17d09a01e10 | Version Fixed In: | 5.45 |
Attachments: | top Qt rendering; bottom Native rendering |
Description
Nate Graham
2018-03-12 20:27:43 UTC
Submitted the patch: https://phabricator.kde.org/D11244 Oops, wrong patch. That one is for Plasma. The QQC2 patch is https://phabricator.kde.org/D11274 Git commit 9a5f7d834f86f57e88c3993fbcf4c17d09a01e10 by Nathaniel Graham. Committed on 13/03/2018 at 13:39. Pushed by ngraham into branch 'master'. Fix font rendering for non-HiDPI and integer scale factors Summary: QQC2-desktop-style was attempting to force the use of `Text.QtRendering` for non-integer scale factors. However, it was accidentally using it everywhere. This patch resolves the issue, and makes it use `Text.QtRendering` only for non-integer scale factors. FIXED-IN: 5.45 Test Plan: No visual changes when there is a non-integer scale factor. System Settings before, no scale factor: {F5751414} System Settings after, no scale factor: {F5751415} Discover before, no scale factor: {F5751416} Discover after, no scale factor: {F5751418} To notice the differences, you will probably have to open them in different tabs, zoom in with {key Meta +}, and switch between the tabs. Reviewers: mart, davidedmundson, broulik Reviewed By: mart, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D11274 M +4 -1 org.kde.desktop/ComboBox.qml M +4 -2 org.kde.desktop/Label.qml M +4 -2 org.kde.desktop/TextArea.qml M +4 -2 org.kde.desktop/TextField.qml https://commits.kde.org/qqc2-desktop-style/9a5f7d834f86f57e88c3993fbcf4c17d09a01e10 |