Bug 391769

Summary:	KOrganizer 5.9.0: Incident times of tasks are not updated when edited by keyboard only
Product:	[Applications] korganizer	Reporter:	Till Schäfer <till2.schaefer>
Component:	incidence editors	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kdenis
Priority:	NOR
Version:	5.9.1
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	https://commits.kde.org/incidenceeditor/10056772fd32c89dd5e881b495f597393b92f2ee	Version Fixed In:	5.9.3
Sentry Crash Report:

Description Till Schäfer 2018-03-12 17:53:19 UTC

When editing the start/due time of an existing task with the keyboard only and clicking ok afterwards, the new values are not saved. This only happens to tasks, but not to calendar entries.  
On the other hand, when selecting the new time by clicking a preset time (i.e., using the drop down list) with the mouse cursor, it works without problems. Even, when some time from the drop down list is selected with the mouse and edited afterwards with the keyboard, the keyboard editing is saved correctly. Thus, I assume that somehow, the keyboard-only edits are not recognized as task modifications.

Comment 1 Till Schäfer 2018-08-21 13:41:08 UTC

still valid for 5.9.0

Comment 2 Denis Kurz 2018-10-10 19:48:12 UTC

https://phabricator.kde.org/D16114

Comment 3 Denis Kurz 2018-10-11 21:26:41 UTC

Git commit 10056772fd32c89dd5e881b495f597393b92f2ee by Denis Kurz.
Committed on 11/10/2018 at 21:26.
Pushed by dkurz into branch 'Applications/18.08'.

Fix keyboard editting of start/end times of VTODOs

Summary:
Editting start/end times of VTODOs using only the keyboard did not
trigger a check whether the VTODO is dirty. If other fields were updated
along with start/end times, everything was fine, but only editting those
times was simply ignored. The patch causes a dirty check for keyboard
edits of the corresponding KTimeComboBoxes.
FIXED-IN: 5.9.3

Test Plan:
I changed start and end times of a test VTODO. Without the patch,
the change was not saved when hitting OK, nor did I hit my dirty-check
breakpoint. With the patch, everything works as expected: Keyboard editting
results in an updated VTODO, as verified via the Month View tooltip and by
opening the IncidenceEditor again for that VTODO. VEVENTs do not have this
problem even without the patch.

Reviewers: #kde_pim, winterz

Reviewed By: #kde_pim, winterz

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D16114

M  +4    -0    src/incidencedatetime.cpp

https://commits.kde.org/incidenceeditor/10056772fd32c89dd5e881b495f597393b92f2ee