Summary: | "Update selected" button is cut off when an app description is opened | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Patrick Silva <bugseforuns> |
Component: | Updates (interactive) | Assignee: | Aleix Pol <aleixpol> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate |
Priority: | NOR | ||
Version: | 5.12.3 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/discover/4cf5247c5a3c174be69b56d0efe98310964160d5 | Version Fixed In: | |
Attachments: | screenshot |
Yeah, it's awfully cramped up there. Perhaps we could make room by getting rid of the "n updates not selected" text. I'm not sure what value that really brings to the user. Patch available at https://phabricator.kde.org/D11214 Better patch: https://phabricator.kde.org/D11218 Git commit 4cf5247c5a3c174be69b56d0efe98310964160d5 by Nathaniel Graham. Committed on 13/03/2018 at 02:18. Pushed by ngraham into branch 'master'. Show all actions on the main Kirigami toolbar and use the secondary one only for status Summary: This is an alternative to D11214 and D11215, and a different method of fixing https://bugs.kde.org/show_bug.cgi?id=391632. I rather prefer it. The patches moves the {nav Update All} button onto the main Kirigami Toolbar, next to {nav Check for Updates}. This allows the secondary white-background toolbar to be used solely for communicating status information, so there is no longer any possibility of an overlap. It also improves the design IMHO, by putting all the action buttons in one place, and all the status information in another. Test Plan: All updates selected: {F5750641} Some updates not selected: {F5750640} Reviewers: apol, #discover_software_store, #vdg Reviewed By: apol, #discover_software_store Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D11218 M +1 -0 discover/qml/DiscoverWindow.qml M +1 -10 discover/qml/UpdatesPage.qml https://commits.kde.org/discover/4cf5247c5a3c174be69b56d0efe98310964160d5 |
Created attachment 111289 [details] screenshot See screenshot.