Bug 391432

Summary:	randomly goes to leave tab on first open
Product:	[Plasma] plasmashell	Reporter:	Harald Sitter <sitter>
Component:	Application Launcher (Kickoff) widget	Assignee:	David Edmundson <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, plasma-bugs, simonandric5, trufanovan
Priority:	NOR
Version:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-desktop/eff339237986bec675303bf512be2bc2d631b90b	Version Fixed In:
Sentry Crash Report:
Attachments:	journal xsession-errors installed packages video

Description Harald Sitter 2018-03-05 13:22:01 UTC

(Doesn't affect 5.12 it seems)

For unknown reasons kickoff randomly switches to the 'leave' tab automatically. This seems to happen a whole lot of times in a neon openqa test which does the following in a cirrus VGA VM:

- login
- lock screen
- switch to new sddm
- login again
- try to log out

at this point kickoff unexpectedly is on the leave tab. I am attaching super verbose qdebug xession-errors + a dump of the journald + list of deb packages and versions + a video of the test run.

Sho_ and bshah suggested they can also reproduce it somewhat on their systems.

Comment 1 Harald Sitter 2018-03-05 13:22:32 UTC

Created attachment 111201 [details]
journal

Comment 2 Harald Sitter 2018-03-05 13:23:06 UTC

Created attachment 111202 [details]
xsession-errors

Comment 3 Harald Sitter 2018-03-05 13:23:35 UTC

Created attachment 111203 [details]
installed packages

Comment 4 Harald Sitter 2018-03-05 13:24:57 UTC

Created attachment 111204 [details]
video

Comment 5 Marco Martin 2018-03-06 16:02:27 UTC

Git commit 3a763498b6a47d273f1d526a2974727af503053d by Marco Martin.
Committed on 06/03/2018 at 16:02.
Pushed by mart into branch 'master'.

use opacity instead of visible

Summary:
Qt documentation recomends to bind to opacity instead of visible as visible
cascades down. The tabbar used to trigger its height behavior anim when the
popup got hidden, binding to opacity (even if opacity isn't animated) is a
more correct behavior.
Plus with visible it triggers the Qt bug https://bugreports.qt.io/browse/QTBUG-66907
which in turn triggers https://bugs.kde.org/show_bug.cgi?id=391432

Test Plan: kickoff never opens the last tab anymore

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11098

M  +10   -5    applets/kickoff/package/contents/ui/FullRepresentation.qml

https://commits.kde.org/plasma-desktop/3a763498b6a47d273f1d526a2974727af503053d

Comment 6 Marco Martin 2018-03-06 16:03:12 UTC

Git commit eff339237986bec675303bf512be2bc2d631b90b by Marco Martin.
Committed on 06/03/2018 at 16:02.
Pushed by mart into branch 'Plasma/5.12'.

use opacity instead of visible

Summary:
Qt documentation recomends to bind to opacity instead of visible as visible
cascades down. The tabbar used to trigger its height behavior anim when the
popup got hidden, binding to opacity (even if opacity isn't animated) is a
more correct behavior.
Plus with visible it triggers the Qt bug https://bugreports.qt.io/browse/QTBUG-66907
which in turn triggers https://bugs.kde.org/show_bug.cgi?id=391432

Test Plan: kickoff never opens the last tab anymore

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11098

M  +10   -5    applets/kickoff/package/contents/ui/FullRepresentation.qml

https://commits.kde.org/plasma-desktop/eff339237986bec675303bf512be2bc2d631b90b

Comment 7 Patrick Silva 2018-05-04 11:26:03 UTC

*** Bug 393828 has been marked as a duplicate of this bug. ***