Bug 391311

Summary:	[Patch] Fix arm64 valgrind tests compilation with clang
Product:	[Developer tools] valgrind	Reporter:	Vasily Tarasov <vtarasov>
Component:	general	Assignee:	Paul Floyd <pjfloyd>
Status:	REPORTED ---
Severity:	normal	CC:	pjfloyd
Priority:	NOR
Version First Reported In:	3.13.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Fix arm64 valgrind tests compilation with clang

Description Vasily Tarasov 2018-03-02 18:49:51 UTC

Created attachment 111149 [details]
Fix arm64 valgrind tests compilation with clang

Android Open Source Project compiles Valgrind using clang, with it's own assember, with semantics different from gcc's.
Switching to external assember with "-no-integrated-as" is not an option, as it doesn't propagate arch feature expansions properly.

The attached patch makes arm64 Valgrind tests compilation clang-friendly:
- per https://developer.arm.com/docs/100069/0607/a64-floating-point-instructions/fcmp
  fcmp accept a floating point zero, replacing #0 with #0.0
- per http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0802b/MOVI_advsimd_vector.html
  movi's 8-bit immediate is not allowed to be shifted, removing LSL #0.
- ifdef-ing crypto assembly with __ARM_FEATURE_CRYPTO. Tests will be included in kryo, and excluded for generic arm64 builds.
- per http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0802b/ADD_addsub_ext.html
  add extended register's 64-bit version, extend is required to be uxtx

Comment 1 Paul Floyd 2024-07-09 07:51:59 UTC

I may well have reinvented this wheel with the port to FreeBSD arm64, which also uses the LLVM toolchain.

Comment 2 Paul Floyd 2024-07-09 11:45:57 UTC

Other than the 

+#if defined(__ARM_FEATURE_CRYPTO)

bits all these have been addressed (and sime without using clang conditional blocks).