| Summary: | Shape Selection tool cannot edit shapes on a selection mask. | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | wolthera <griffinvalley> |
| Component: | Layers/Vector | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla, raghu |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
For some reason, select->convert to vector selection is active and does nothing in 4.0. In 3.3.3, I first had to convert to vector selection(despite making a vector selection to begin with), but after that I could select it... There is also a weird assert when I try to create a vector selection... Git commit aa81a25fd338f49901dd09c551c48cc6e8fd37f6 by Dmitry Kazakov. Committed on 06/04/2018 at 13:51. Pushed by dkazakov into branch 'master'. Fix an assert when creating a vector selection The problem is that selectionChanged() signal may easily arrive later than some GUI code requests the shape manager, therefore the assert will register an inconsistent state (which is actually, yes, inconsistent) M +15 -6 libs/ui/canvas/kis_canvas2.cpp https://commits.kde.org/krita/aa81a25fd338f49901dd09c551c48cc6e8fd37f6 Git commit 231608eda1d253309825cd96459a9a92a89273a1 by Dmitry Kazakov. Committed on 07/04/2018 at 13:28. Pushed by dkazakov into branch 'krita/4.0'. Fix an assert when creating a vector selection The problem is that selectionChanged() signal may easily arrive later than some GUI code requests the shape manager, therefore the assert will register an inconsistent state (which is actually, yes, inconsistent) M +15 -6 libs/ui/canvas/kis_canvas2.cpp https://commits.kde.org/krita/231608eda1d253309825cd96459a9a92a89273a1 +1 Earlier i could edit the selection (resize and move) with the shape selection tool now the functionality is not there incidentally if I double click the selection I can enter in to node editing. The bug is fixed now in master :) |
To reproduce. 1. Make a selection with the selection tools, with the selection set to 'vector'. 2. Select the global selection mask. 3. Select the shape select tool. 4. Try to select the shape on the global selection mask. I though initially it was because of that floating popup thing, but the following patch makes NO difference for me when it comes to actually selecting the shape on the selection mask. ----------------------------------------------------------------------------- diff --git a/plugins/tools/defaulttool/defaulttool/DefaultTool.cpp b/plugins/tools/defaulttool/defaulttool/DefaultTool.cpp index bffae46..e800e22 100644 --- a/plugins/tools/defaulttool/defaulttool/DefaultTool.cpp +++ b/plugins/tools/defaulttool/defaulttool/DefaultTool.cpp @@ -677,12 +677,12 @@ void DefaultTool::paint(QPainter &painter, const KoViewConverter &converter) // this tool only works on a vector layer right now, so give a warning if another layer type is trying to use it KisNodeSP currentNode = canvas()->resourceManager()->resource(KisCanvasResourceProvider::CurrentKritaNode).value<KisNodeWSP>(); - if (currentNode.isNull() || !currentNode->inherits("KisShapeLayer")) { + if (currentNode.isNull() || (!currentNode->inherits("KisShapeLayer") && !currentNode->inherits("KisSelectionMask"))) { KisCanvas2 * kiscanvas = static_cast<KisCanvas2*>(canvas()); kiscanvas->viewManager()->showFloatingMessage( i18n("This tool only works on vector layers. You probably want the move tool."), - QIcon(), 2000, KisFloatingMessage::Medium, Qt::AlignCenter); + QIcon(), 500, KisFloatingMessage::Medium, Qt::AlignCenter); return; }