| Summary: | Smudge brush cannot draw black on masks | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | ZSpratt <zachman331> |
| Component: | Brush engines | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | griffinvalley, halla |
| Priority: | NOR | Keywords: | regression |
| Version: | 4.0.0-beta.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/krita/677b1f6a1d3b2dcdecb6309ce13e77808f59a1a7 | Version Fixed In: | |
|
Description
ZSpratt
2018-03-01 22:03:11 UTC
Caused by the colorsmudge fix after the first beta. From what I gather, the problem is on ln 282 in the composite there. You see, transparency masks are alpha colorspaces. I think it's confused on how to handle this alpha color space, because there black is transparent! So it just goes, well, this is transparent, let's not do anything :p Some qdebugs show this quite clearly: With darkgray: Color "Alpha 63335" dulling "Alpha 46893" dulling after composite "Alpha 47741" with black Color "Alpha 0" dulling "Alpha 65535" dulling after composite "Alpha 65535" Git commit 7598fff3f4c9e5058f17b3ff5252782ce0c9fdd2 by Dmitry Kazakov. Committed on 02/04/2018 at 14:16. Pushed by dkazakov into branch 'master'. Fix painting with colorsmudge brushes on transparency masks We should create a correct composition source device. The precise copy of the device cannot create it correctly, we should do that manually. M +24 -0 libs/image/KisPrecisePaintDeviceWrapper.cpp M +14 -0 libs/image/KisPrecisePaintDeviceWrapper.h M +7 -8 plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp https://commits.kde.org/krita/7598fff3f4c9e5058f17b3ff5252782ce0c9fdd2 Git commit 677b1f6a1d3b2dcdecb6309ce13e77808f59a1a7 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 03/04/2018 at 11:20. Pushed by rempt into branch 'krita/4.0'. Fix painting with colorsmudge brushes on transparency masks We should create a correct composition source device. The precise copy of the device cannot create it correctly, we should do that manually. (cherry picked from commit 7598fff3f4c9e5058f17b3ff5252782ce0c9fdd2) M +24 -0 libs/image/KisPrecisePaintDeviceWrapper.cpp M +14 -0 libs/image/KisPrecisePaintDeviceWrapper.h M +7 -8 plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp https://commits.kde.org/krita/677b1f6a1d3b2dcdecb6309ce13e77808f59a1a7 |