Bug 391206

Summary:	Does not prompt user to save or discard changes upon closing dialog
Product:	[Applications] dolphin	Reporter:	Zakhar <zakhar.nasimov>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	elvis.angelaccio, nate
Priority:	NOR	Keywords:	junior-jobs, usability
Version First Reported In:	17.12.2
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	https://commits.kde.org/dolphin/017cd2322a0ae4c57476871f7715904a7810c9d3	Version Fixed/Implemented In:	19.08.0
Sentry Crash Report:

Description Zakhar 2018-02-28 05:04:59 UTC

Steps to reproduce:
-Open dolphin
-Goto configure dolphin
-change a few settingssetting
-close settings dialog

Result: app doesn't ask if you wanted to save or discard changes

What should have happened: app should have asked wether or not you wanted to save or discard changes.

Comment 1 Amish Naidu 2019-03-26 08:54:01 UTC

Git commit 017cd2322a0ae4c57476871f7715904a7810c9d3 by Amish Naidu.
Committed on 26/03/2019 at 08:53.
Pushed by anaidu into branch 'master'.

Prompt user to save/discard changes upon closing config dialog

Summary:
When the configuration dialog is closed with unsaved changes,
a message box is prompted to save/discard them or cancel the event.

Reviewers: #dolphin, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: ngraham, elvisangelaccio, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19904

M  +34   -1    src/settings/dolphinsettingsdialog.cpp
M  +4    -0    src/settings/dolphinsettingsdialog.h

https://commits.kde.org/dolphin/017cd2322a0ae4c57476871f7715904a7810c9d3