| Summary: | KNS Reviews have mangled headers and i18n() errors | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
| Component: | KNewStuff Backend | Assignee: | Aleix Pol <aleixpol> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | leinir |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/discover/8a823402b74c1f772036a4a14b449ede20a9a23d | Version Fixed In: | |
| Attachments: |
Comparison between Discover and store.kde.org: mangled headers and i18n errors
Still broken, just in a different way |
||
Git commit 3f0b8f91289741fbd16d30b8607463b2c3e644e0 by Aleix Pol. Committed on 01/03/2018 at 12:52. Pushed by apol into branch 'Plasma/5.12'. Make sure there's a subject, otherwise i18n() goes mental M +3 -1 libdiscover/backends/KNSBackend/KNSReviews.cpp https://commits.kde.org/discover/3f0b8f91289741fbd16d30b8607463b2c3e644e0 Created attachment 111112 [details]
Still broken, just in a different way
Hmm, not sure that fixed it. Now the name is in the right place, but the title is blank. It still looks bad, just in a different way. See attached screenshot.
Git commit 8a823402b74c1f772036a4a14b449ede20a9a23d by Aleix Pol. Committed on 02/03/2018 at 13:21. Pushed by apol into branch 'master'. Offer an alternative header in case there's no subject for a review store.kde.org reviews don't have a title nowadays. M +2 -1 discover/qml/ReviewDelegate.qml https://commits.kde.org/discover/8a823402b74c1f772036a4a14b449ede20a9a23d Verified, much better now! |
Created attachment 111071 [details] Comparison between Discover and store.kde.org: mangled headers and i18n errors See attached screenshot. It looks like the reviewer name is being used as the title, and nothing's being set for the reviewer name.