| Summary: | Discover's sort menu inappropriately uses checkboxes instead of radio buttons | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
| Component: | discover | Assignee: | Aleix Pol <aleixpol> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | simonandric5 |
| Priority: | NOR | ||
| Version: | 5.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/discover/fb21b21bd699dad9cf03d8e2553797cadee728cd | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2018-02-27 05:13:09 UTC
Needs changes in few parts of the stack. First in: https://commits.kde.org/qqc2-desktop-style/55dbbdb9315c81b89e255d4b576b9697083db698 Git commit 9ca92183166a0c9292ee4cc883a00c507692c751 by Aleix Pol. Committed on 28/02/2018 at 14:48. Pushed by apol into branch 'master'. Make it possible to support exclusive action groups Summary: We need to find away to import 2.3 if available otherwise modelData.Controls.ActionGroup returns null. Reviewers: #kirigami, mart Reviewed By: #kirigami, mart Subscribers: mart, plasma-devel Tags: #kirigami Differential Revision: https://phabricator.kde.org/D10892 M +7 -0 src/CMakeLists.txt C +13 -23 src/controls/private/ActionMenuItemBase.qml [from: src/controls/private/ActionsMenu.qml - 051% similarity] C +4 -25 src/controls/private/ActionMenuItemQt510.qml [from: src/controls/private/ActionsMenu.qml - 051% similarity] C +1 -27 src/controls/private/ActionMenuItemQt59.qml [from: src/controls/private/ActionsMenu.qml - 050% similarity] M +3 -15 src/controls/private/ActionsMenu.qml M +35 -10 tests/actionsMenu.qml https://commits.kde.org/kirigami/9ca92183166a0c9292ee4cc883a00c507692c751 Git commit fb21b21bd699dad9cf03d8e2553797cadee728cd by Aleix Pol. Committed on 28/02/2018 at 15:11. Pushed by apol into branch 'master'. Use an action group for the sort options Summary: Otherwise we get ugly checkboxes. Requires Qt 5.10. Depends on D10892 Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D10893 M +12 -4 discover/qml/ApplicationsListPage.qml https://commits.kde.org/discover/fb21b21bd699dad9cf03d8e2553797cadee728cd I'm afraid those patches didn't resolve the issue for me. Both are committed, yet I still see checkboxes in Discover's sort menu. Missed the patch for QQC2-desktop-style. Can verify that this is fixed now! |