| Summary: | KPopupAccelManager::setMenuEntries() is unconditionally setting QAction::setIconText() | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kwidgetsaddons | Reporter: | Christian Ehrlicher <Ch.Ehrlicher> |
| Component: | general | Assignee: | Christoph Feck <cfeck> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kdelibs-bugs |
| Priority: | NOR | ||
| Version: | 5.43.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwidgetsaddons/7fe64f532d381bb43ecc03fa6d94e59f3c30ba1d | Version Fixed In: | |
|
Description
Christian Ehrlicher
2018-02-24 11:46:04 UTC
Thanks Christian for the investigation. Do I understand it correctly, that moving the setIconText() call into the 'if' (after line 793) is sufficient to fix the issue? When you set the iconText only when the text is changed it would at least fix the bug report I would guess. The problem is that it's unknown if the iconText is set programatically or not and even watching for QEvent::ActionChanged does not really help... btw: The change was introduced with https://phabricator.kde.org/D7964 Git commit 7fe64f532d381bb43ecc03fa6d94e59f3c30ba1d by Christoph Feck. Committed on 30/03/2018 at 00:18. Pushed by cfeck into branch 'master'. [KAcceleratorManager] Only set iconText() if actually changed QAction::setIconText() breaks the feature that QAction::iconText() is returning text() when the iconText is empty. Reviewed by Christian Ehrlicher Differential Revision: https://phabricator.kde.org/D11346 M +3 -1 src/kacceleratormanager.cpp https://commits.kde.org/kwidgetsaddons/7fe64f532d381bb43ecc03fa6d94e59f3c30ba1d |