Bug 390932

Summary:	Update default exclude filters
Product:	[Frameworks and Libraries] frameworks-baloo	Reporter:	cotkocot
Component:	general	Assignee:	baloo-bugs-null
Status:	RESOLVED FIXED
Severity:	normal	CC:	andrey.vetlugin, danakil, kde
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/baloo/7529727e46242d2fdd71c4e8c92363600373fcb6	Version Fixed In:
Sentry Crash Report:

Description cotkocot 2018-02-22 23:45:40 UTC

Checking the default exclude filters (https://github.com/KDE/baloo/blob/8f4638b42d40c851c9d934104796e111e559234b/src/file/fileexcludefilters.cpp) after seeing them in the ~/.config/baloofilerc I think they should be updated at least with (folders):

node_modules/
.npm
.yarn
.yarn-cache
bower_components

there's a lot of us who use nodejs and those folders can contain tons and tons of files (bigger projects usually have node_modules > 1GB, especially now that facebook's react native became quite popular) which are completely needlessly scanned. Since you already have a list of code related folders in the default exclusion, I believe those should be added as well.

Comment 1 Kai Uwe Broulik 2018-02-23 12:07:23 UTC

I agree that it makes sense to blacklist them also. Since you already found the correct source file to edit, would you mind creating a patch for us? :) For documentation regarding how to do this, see https://community.kde.org/Infrastructure/Phabricator
Thanks!

Comment 2 DanaKil 2018-02-25 12:26:38 UTC

(In reply to cotkocot from comment #0)
> Checking the default exclude filters
> (https://github.com/KDE/baloo/blob/8f4638b42d40c851c9d934104796e111e559234b/
> src/file/fileexcludefilters.cpp) after seeing them in the
> ~/.config/baloofilerc I think they should be updated at least with (folders):
...

Very good suggestion indeed !

May I suggest to add "nbproject" which is the configuration folder for Netbeans projects (https://netbeans.org/) or is it too specific ? 
Actually these nbproject folders only contains some lightweight files (.ini style files, xml files...) so it's not really a problem but these files are nevertheless irrelevant for a user.

Comment 3 Nate Graham 2018-05-15 22:40:41 UTC

Git commit 7529727e46242d2fdd71c4e8c92363600373fcb6 by Nathaniel Graham.
Committed on 15/05/2018 at 22:33.
Pushed by ngraham into branch 'master'.

Ignore more types of source files

Summary:
Add more types of development-related files to the exclusion lists. These files aren't useful to index, and having them there can bog down Baloo.
Related: bug 394002, bug 382117
FIXED-IN 5.47

Test Plan: Created a bunch of files of the newly excluded types. Baloo didn't index them.

Reviewers: michaelh, bruns

Reviewed By: bruns

Subscribers: broulik, cfeck, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D12787

M  +37   -5    src/file/fileexcludefilters.cpp

https://commits.kde.org/baloo/7529727e46242d2fdd71c4e8c92363600373fcb6

Comment 4 Nate Graham 2018-06-28 19:09:04 UTC

*** Bug 395959 has been marked as a duplicate of this bug. ***