Bug 390835

Summary:	verview docker incorrectly displays current view and the image appears too small/low quality when full size.
Product:	[Applications] krita	Reporter:	Isaac Zuniga <isaaczuniga>
Component:	Dockers	Assignee:	Marcin <lambda777>
Status:	RESOLVED FIXED
Severity:	minor	CC:	edan.mizrahi.260, halla, lambda777, seoras1
Priority:	NOR	Keywords:	triaged
Version:	3.3.3
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:
Attachments:	Fix for blurriness/distortion

Description Isaac Zuniga 2018-02-21 06:37:27 UTC

A few things going on here, but I think that the biggest issue is that the overview docker is reporting an incorrect view of the document. I was able to reproduce the issue on Krita 3.3.3 up to the current nightly build. (10:31 PM PST of 2/20/2018.)

Krita 3.3.3 video: https://drive.google.com/file/d/1J8y2hZZs4evYIVzyEVqSow0SDsgmAt5C/view?usp=sharing

Krita nightly build (10:31 PM PST as of 2/20/2018): https://drive.google.com/file/d/1ckFRvyZbhS-oVphLyyAHbD_Ckpry5fLo/view?usp=sharing

There's another issue as well, the image does not appear properly in the overview docker. It's too small, and when the docker is resized, the canvas fills up the docker, but the image is extremely fuzzy.

Although, to give credit where it's due, when the image is filling up the docker, the current view IS APPROPRIATELY depicted. Unfortunately, the image is too fuzzy and it only lasts for about 3 seconds before the image becomes tiny again.

Comment 1 Isaac Zuniga 2018-02-22 16:14:54 UTC

This looks quite ugly: https://drive.google.com/file/d/1S_XUdpjeezV1Aig45FJMlWwY17-_Stbg/view?usp=sharing

You are able to resize the overview docker and it greatly distorts the image until it's nothing more than a blurred mess, and if you keep doing it, sooner or later, the depicted canvas in the docker will only be 1 pixel wide.

Comment 2 Halla Rempt 2018-02-27 14:15:37 UTC

The fuzziness of the image is normal: it is not possible to scale the image at interactive speeds so it always stays sharp. After resizing stops, it'll recalculate the image and show it sharper. I do see that the size of the preview is broken, though.

Comment 3 Halla Rempt 2018-02-27 14:20:24 UTC

This size of the image in the docker was already broken in 3.0.1.1 at least.

Comment 4 Seoras Macdonald 2018-04-06 15:19:03 UTC

Created attachment 111873 [details]
Fix for blurriness/distortion

I've got a fix for the blurriness/distortion part of the bug, but not for the incorrect size.

I've introduced an m_oldPixmap variable which stays constant over calls to resizeEvent, and m_pixmap is now set to a scaled version of this, rather than a scaled version of itself (which seemed to be the cause of the distortion.)

I'll post the patch for review on phabricator.

Comment 5 Halla Rempt 2018-04-09 08:56:55 UTC

Git commit 82a8db752ebc715ff0b0343cd34c054d3adeaa5f by Boudewijn Rempt.
Committed on 09/04/2018 at 08:53.
Pushed by rempt into branch 'master'.

Overview docker: fix shrinking the thumbnail to 1px

Differential Revision: https://phabricator.kde.org/D11988

M  +3    -2    plugins/dockers/overview/overviewwidget.cc
M  +1    -0    plugins/dockers/overview/overviewwidget.h

https://commits.kde.org/krita/82a8db752ebc715ff0b0343cd34c054d3adeaa5f

Comment 6 Halla Rempt 2018-04-09 08:59:23 UTC

Git commit 9863e5e92d4a1daed56b839e34ea8b20a3a6ec79 by Boudewijn Rempt.
Committed on 09/04/2018 at 08:57.
Pushed by rempt into branch 'krita/4.0'.

Overview docker: fix shrinking the thumbnail to 1px

Differential Revision: https://phabricator.kde.org/D11988

(cherry picked from commit 82a8db752ebc715ff0b0343cd34c054d3adeaa5f)

M  +3    -2    plugins/dockers/overview/overviewwidget.cc
M  +1    -0    plugins/dockers/overview/overviewwidget.h

https://commits.kde.org/krita/9863e5e92d4a1daed56b839e34ea8b20a3a6ec79

Comment 7 Halla Rempt 2018-04-26 17:25:10 UTC

*** Bug 393549 has been marked as a duplicate of this bug. ***

Comment 8 Halla Rempt 2018-10-16 07:20:56 UTC

Should be fixed in 8eada506df649626fd994103ab78fe615608bcfb