| Summary: | Muon downloads Changelog even if the tab is not shown | ||
|---|---|---|---|
| Product: | [Unmaintained] muon | Reporter: | Carlo Vanini <silhusk> |
| Component: | muon | Assignee: | Jonathan Thomas <echidnaman> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | silhusk |
| Priority: | NOR | ||
| Version First Reported In: | 5.6 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/muon/02b64d3db27732dda524c4c635cbe36e3ef87261 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Carlo Vanini
2018-02-20 14:06:08 UTC
Git commit 02b64d3db27732dda524c4c635cbe36e3ef87261 by Carlo Vanini. Committed on 14/03/2018 at 18:11. Pushed by vanini into branch 'master'. Lazily refresh the details tabs Summary: Refresh only the current tab when the selected package is changed. Before, every tab was refreshed. That included getting the list of installed files and downloading the changelog, even if that information was not presented to the user. The UI has a small change in that before, when a tab had nothing to show (e.g. no alternative version available for the package) the tab itself was hidden. After the change, the tab is still visible but it is grayed out and cannot be selected (i.e. inactive). Reviewers: sitter Reviewed By: sitter Differential Revision: https://phabricator.kde.org/D11206 M +4 -0 src/DetailsTabs/ChangelogTab.cpp M +1 -0 src/DetailsTabs/ChangelogTab.h M +0 -1 src/DetailsTabs/DetailsTab.cpp M +4 -0 src/DetailsTabs/InstalledFilesTab.cpp M +1 -0 src/DetailsTabs/InstalledFilesTab.h M +4 -0 src/DetailsTabs/VersionTab.cpp M +1 -0 src/DetailsTabs/VersionTab.h M +17 -9 src/DetailsWidget.cpp M +1 -1 src/DetailsWidget.h M +1 -1 src/PackageModel/PackageWidget.cpp https://commits.kde.org/muon/02b64d3db27732dda524c4c635cbe36e3ef87261 |