Bug 390780

Summary: Loading combined fragments from xmi file adds unwanted else part
Product: [Applications] umbrello Reporter: Ralf Habacker <ralf.habacker>
Component: generalAssignee: Umbrello Development Group <umbrello-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 2.24.1 (KDE Applications 17.12.1)   
Target Milestone: ---   
Platform: Other   
OS: All   
Latest Commit: https://commits.kde.org/umbrello/4000ba1327de96091ca3ffd9df2611eca235ce91 Version Fixed In: 2.24.3 (KDE Applications 17.12.3)

Description Ralf Habacker 2018-02-20 13:12:12 UTC 
In case an alternate combined fragment has been created in a sequence diagram and the "else" part has been removed, it will be readded after a file save/load cycle resulting into "auto" modified diagrams having an unwanted "else" part.

How to reproduce: 
1. start umbrello
2. Add an alternate combined fragment widget to a sequence diagram with the default first alternative name
3. remove the "else part"
4. save the file
5. load the file

What happens ?
The else part has been readded to the diagram and will be saved on further saves modified the diagram in an unwanted way

What is expected ?
The else part should not be added by default on file loading
Comment 1 Ralf Habacker 2018-02-20 13:31:00 UTC 
Git commit 4000ba1327de96091ca3ffd9df2611eca235ce91 by Ralf Habacker.
Committed on 20/02/2018 at 13:30.
Pushed by habacker into branch 'Applications/17.12'.

Fix 'Loading combined fragments from xmi file adds unwanted else part'

Only add an FloatingDashLineWidget instance if the widget has not been
created in the loading state.
FIXED-IN:2.24.3 (KDE Applications 17.12.3)

M  +2    -1    umbrello/umlwidgets/combinedfragmentwidget.cpp

https://commits.kde.org/umbrello/4000ba1327de96091ca3ffd9df2611eca235ce91