Bug 390744

Summary:	Parenthesis 2 error
Product:	[Applications] tellico	Reporter:	kbutra2442
Component:	general	Assignee:	Robby Stephenson <robby>
Status:	RESOLVED UPSTREAM
Severity:	crash
Priority:	NOR
Version First Reported In:	3.1.1
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description kbutra2442 2018-02-19 16:40:28 UTC

Hi,
first, thanks for this great piece of software!

I experienced crashes with tellico which I sorted out a little.
If there's "*(2*.jpg" ( that's opening parenthesis AND a "2") file in a directory when "import file catalogue" / "Dateikatalog importieren" is started, tellico will crash.

This doesn't happen with .jpg's containing (1,(3,(4 or the like, only with (2 .

Since I can reproduce with all .jpgs I put at it, I won't attach a .jpg until I get asked.

Steps to reproduce:

1. Put .jpg with "(2" in it's filename in a directory.
2. Start tellico -> select file -> import -> import file catalogue -> Click import

Comment 1 kbutra2442 2018-02-19 22:00:28 UTC

Ok, after further investigation, this could be a problem with exiv2.
Tellico also crashes when there are .png files with XMP tags I think.

Sorry for not providing much information, but the pure count of debugging tools and the corresponding how-to's (application specific) still give me a headache at the moment, so I fear providing wrong/irrelevant information is worse.

Comment 2 Robby Stephenson 2018-02-27 02:45:04 UTC

Git commit 74cd5ca785e1ea5ca746098fce3efc99858eb7d7 by Robby Stephenson.
Committed on 27/02/2018 at 02:31.
Pushed by rstephenson into branch '3.1'.

Add a unit test to expose crashing bug when reading XMP data

BlueSquare.jpg is a test file from the exiv library. Linking to
EXEMPI causes a crash, no matter whether XMPHandler is initialized or
not

M  +4    -0    src/tests/CMakeLists.txt
A  +-    --    src/tests/data/BlueSquare.jpg
M  +29   -1    src/tests/filelistingtest.cpp
M  +1    -0    src/tests/filelistingtest.h

https://commits.kde.org/tellico/74cd5ca785e1ea5ca746098fce3efc99858eb7d7

Comment 3 Robby Stephenson 2018-03-14 03:34:57 UTC

Git commit 62a17e3ac3bf617f5c054a38d00a662d2b72be28 by Robby Stephenson.
Committed on 14/03/2018 at 03:32.
Pushed by rstephenson into branch '3.1'.

Add workaround for crash when linking to Exempi and reading Exiv data

For now, add a very crude workaround to avoid using the EXIV metadata
extractor from KFileMetaData when Exempi is also used. I can't figure
out how to avoid the crash otherwise.

M  +8    -1    src/tests/filelistingtest.cpp
M  +4    -4    src/translators/CMakeLists.txt
M  +14   -2    src/translators/filelistingimporter.cpp

https://commits.kde.org/tellico/62a17e3ac3bf617f5c054a38d00a662d2b72be28