| Summary: | Show pick and color label in thumbnail list [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Andreas Studer <studer> |
| Component: | Preview-Image | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | antonio.angelo, caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version: | 5.7.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/digikam/d0bef3f96ff643e594617ccc96111832c0d6cc57 | Version Fixed In: | 5.9.0 |
| Sentry Crash Report: | |||
| Attachments: |
ThumbPickLabel.patch
PickLabel1.png PickLabel2.png |
||
|
Description
Andreas Studer
2018-02-18 16:54:48 UTC
On the right side bar, in Comments tab, all digiKam properties are always visible. Yes, I know. The point is you don't see them in the overview. You hve to click every single image to find out what state it has. It also doesn't help to filter them, because that is something you'll do after you've done the pickling work. Maybe it is also a question of an efficient workflow. IMO you need something like the Preview view for the initial picking of images after you've downloaded them from the camera, as you need a bigger view for that. As I said Lightroom has that sort of workflow for storing and picking images and digikam is very close in that part; except it misses that picking in Preview mode. Maybe professionals always work with 5 star ratings for picking images. Something I personally don't see as efficient as it is alot more difficult that just say: Keep the picture, don't keep the picture, This picture needs a closer look. This is something you can do with keyboard shortcuts very easily too as you're browsing through the loaded pictures. In fact I don't use the stars feature in Lightroom at all, and I wouldn't use it in Digikam too as the flags in Digikam would be the feature I really need. As it is already there, it seems to me an easy addition to the thumbnails / icons in the Preview view. Created attachment 110824 [details]
ThumbPickLabel.patch
Gilles,
What do you think? Also, whether flexible size or fixed size like the rating widget? Or should the rating widget also scale?
Maik
The question is : why we need to scale overlay widgets from thumbnails view. After all thumbbar is based on same model view than icon view. It can be not too diffucult to reuse and factorize implementations from icon-view to thumbbar. Typically, when digiKam have been ported to Qt4, we use the model view programming in this goal : to have the same rendering on both views. Of course not all information from icon view can be displayed to thumbbar, but at least, if most important overlay can be available, this will be a big step. We must to have a comparison between both views and select what's missing exactly to improve users workflow, as explained in comment #2 Gilles Andeas, i'm not sure to understand your orignal comment, especially for : "In the thumbnails view, you'll see ratings, the pick label and color label according to the configuration of Settings --> Views --> Icons. However, in the Preview view, you'll only see ratings and color label. The Pick-Label is not shown" What do you mean by preview view ? Can you take screenshots to compare visually where the information in missing in views ? Gilles Caulier Created attachment 110860 [details]
PickLabel1.png
DigiKam now, color label and rating visible in the preview mode thumbbar, pick label not.
Maik
Created attachment 110861 [details]
PickLabel2.png
DigiKam with patch, pick label now also visible.
Maik
ok, now i see the difference. If the patch work as expected in all thumbbars (preview, editor, LT), and horizontally/vertically, all is fine. Git commit 3f96d37ad60c78f55184cc09aae653e4b165b2cf by Maik Qualmann. Committed on 21/02/2018 at 11:27. Pushed by mqualmann into branch 'development/6.0.0'. add show pick label in the thumb bar M +2 -1 NEWS M +1 -0 app/items/imagethumbnaildelegate.cpp https://commits.kde.org/digikam/3f96d37ad60c78f55184cc09aae653e4b165b2cf diff --git a/NEWS b/NEWS index 683af98952..e86c33179d 100644 --- a/NEWS +++ b/NEWS @@ -30,4 +30,5 @@ BUGFIXES FROM BUGZILLA: Git commit d0bef3f96ff643e594617ccc96111832c0d6cc57 by Maik Qualmann. Committed on 21/02/2018 at 11:24. Pushed by mqualmann into branch 'master'. add show pick label in the thumb bar BUGS: 390688 FIXED-IN: 5.9.0 M +2 -1 NEWS M +1 -0 app/items/imagethumbnaildelegate.cpp https://commits.kde.org/digikam/d0bef3f96ff643e594617ccc96111832c0d6cc57 Git commit d0bef3f96ff643e594617ccc96111832c0d6cc57 by Maik Qualmann. Committed on 21/02/2018 at 11:24. Pushed by mqualmann into branch 'master'. add show pick label in the thumb bar FIXED-IN: 5.9.0 M +2 -1 NEWS M +1 -0 app/items/imagethumbnaildelegate.cpp https://commits.kde.org/digikam/d0bef3f96ff643e594617ccc96111832c0d6cc57 Thanks a lot for adding that small thing. ;-) *** Bug 402729 has been marked as a duplicate of this bug. *** |