Bug 390658

It does not crash for me here. Can you provide a backtrace?

Created attachment 110784 [details]
attachment-17479-0.html

I'd be happy to provide it.  I just need some instructions on how to do the
trace.

On Sun, Feb 18, 2018 at 7:30 AM, Thomas Baumgart <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=390658
>
> --- Comment #1 from Thomas Baumgart <tbaumgart@kde.org> ---
> It does not crash for me here. Can you provide a backtrace?
>
> --
> You are receiving this mail because:
> You reported the bug.

I cannot reproduce your crash too.

Could you attach screenshots of currencies window and its edit window for USD?

If you experience crash, then drkonqi should fire up with backtrace or instruction how to get it. It should look like this
https://farm4.staticflickr.com/3557/3410899444_75970652eb.jpg

Created attachment 110825 [details]
screen shot of where I click ok then crash

Created attachment 110826 [details]
rerun gdb

I reran gdb with added results. installed drkongi and Konqueror that created no results or execution.

something is telling me this is maybe related to the price precision.  Previously in older versions there was a global setting where you could change this figure.  Mine was/is set to 4 and I can't change it.  Now that setting is gone and the smallest cash & money unit is 2 digits.  Anytime I save it I think it's conflicting and maybe be causing the crash.  Just a thought.

(In reply to Michael Carpino from comment #7)
> something is telling me this is maybe related to the price precision. 
> Previously in older versions there was a global setting where you could
> change this figure.  Mine was/is set to 4 and I can't change it.  Now that
> setting is gone and the smallest cash & money unit is 2 digits.  Anytime I
> save it I think it's conflicting and maybe be causing the crash.  Just a
> thought.

Price precision has been enhanced by per security/currency setting.
Do you mean that you can't change it from 4 to 2 now?

There are two things I would like you to do:

1) open your kmy file in e.g. kwrite and change

rounding-method="0"

to

rounding-method="7"

Make a backup before.
It's a wild guess, so it may bring you nothing.

2) check if you've got exact the same problem with fresh kmy file.

Created attachment 110850 [details]
Screenshot_20180220_110640.png

Here's a screenshot of what I get when I open .kmy with kwrite.  That's
correct it can't be changed and crash is caused if I leave it the same or
try to change it and I press ok.

On Tue, Feb 20, 2018 at 10:24 AM, NSLW <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=390658
>
> --- Comment #8 from NSLW <lukasz.wojnilowicz@gmail.com> ---
> (In reply to Michael Carpino from comment #7)
> > something is telling me this is maybe related to the price precision.
> > Previously in older versions there was a global setting where you could
> > change this figure.  Mine was/is set to 4 and I can't change it.  Now
> that
> > setting is gone and the smallest cash & money unit is 2 digits.  Anytime
> I
> > save it I think it's conflicting and maybe be causing the crash.  Just a
> > thought.
>
> Price precision has been enhanced by per security/currency setting.
> Do you mean that you can't change it from 4 to 2 now?
>
> There are two things I would like you to do:
>
> 1) open your kmy file in e.g. kwrite and change
>
> rounding-method="0"
>
> to
>
> rounding-method="7"
>
> Make a backup before.
> It's a wild guess, so it may bring you nothing.
>
> 2) check if you've got exact the same problem with fresh kmy file.
>
> --
> You are receiving this mail because:
> You reported the bug.

This is a compressed file. Using it as is with any editor does not make sense. Please take a look at https://docs.kde.org/stable4/en/extragear-office/kmymoney/details.formats.html to determine how to make this readable (it's an XML file).

I doubt that rounding has anything todo with your crash.

Created attachment 110856 [details]
attachment-25851-0.html

Thanks Thomas!


I changed the file to xml and then did some looking around.  What are your
thoughts on changing in this section below the pp="4" to a 2?

 </SECURITIES>
 <CURRENCIES count="1">
  <CURRENCY scf="100" symbol="$" pp="4" type="3" rounding-method="0"
name="US Dollar" id="USD" saf="100"/>
 </CURRENCIES>
 <PRICES count="63">

On Tue, Feb 20, 2018 at 11:55 AM, Thomas Baumgart <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=390658
>
> --- Comment #10 from Thomas Baumgart <tbaumgart@kde.org> ---
> This is a compressed file. Using it as is with any editor does not make
> sense.
> Please take a look at
> https://docs.kde.org/stable4/en/extragear-office/kmymoney/
> details.formats.html
> to determine how to make this readable (it's an XML file).
>
> I doubt that rounding has anything todo with your crash.
>
> --
> You are receiving this mail because:
> You reported the bug.
>

Created attachment 110858 [details]
attachment-26507-0.html

I did change it as I made a backup file.  Opened KMM and saw that it was
changed when I viewed the edit of USD and was set to a 2.  Clicked ok and
crash.

On Tue, Feb 20, 2018 at 12:10 PM, Michael Carpino <mfcarpino@gmail.com>
wrote:

> Thanks Thomas!
>
>
> I changed the file to xml and then did some looking around.  What are your
> thoughts on changing in this section below the pp="4" to a 2?
>
>  </SECURITIES>
>  <CURRENCIES count="1">
>   <CURRENCY scf="100" symbol="$" pp="4" type="3" rounding-method="0"
> name="US Dollar" id="USD" saf="100"/>
>  </CURRENCIES>
>  <PRICES count="63">
>
> On Tue, Feb 20, 2018 at 11:55 AM, Thomas Baumgart <
> bugzilla_noreply@kde.org> wrote:
>
>> https://bugs.kde.org/show_bug.cgi?id=390658
>>
>> --- Comment #10 from Thomas Baumgart <tbaumgart@kde.org> ---
>> This is a compressed file. Using it as is with any editor does not make
>> sense.
>> Please take a look at
>> https://docs.kde.org/stable4/en/extragear-office/kmymoney/de
>> tails.formats.html
>> to determine how to make this readable (it's an XML file).
>>
>> I doubt that rounding has anything todo with your crash.
>>
>> --
>> You are receiving this mail because:
>> You reported the bug.
>>
>
>

Problem only shows if you edit the base currency. Fix is underway.

Git commit 20e629fc6bbaa5aa0f0ac43144fb1e25b66dff68 by Thomas Baumgart.
Committed on 03/03/2018 at 14:01.
Pushed by tbaumgart into branch '5.0'.

Don't crash when editing the base currency

Using Tools/Currencies on the selected base currency and hitting Enter
caused a crash. This patch avoids the crash.
FIXED-IN: 5.0.1

M  +10   -2    kmymoney/models/equitiesmodel.cpp

https://commits.kde.org/kmymoney/20e629fc6bbaa5aa0f0ac43144fb1e25b66dff68