Bug 390581

Summary:	Toggle layer visibility clears un-do history
Product:	[Applications] krita	Reporter:	Quiralta <rjquiralte>
Component:	Layer Stack	Assignee:	Dmitry Kazakov <dimula73>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://commits.kde.org/krita/8f6856236d549f50b70d337ed0aac0c00b5da194	Version Fixed In:

Description Quiralta 2018-02-16 19:57:54 UTC

I'm re posting this as It seems to be different from 389876 after all, the clearing of the un-do history can create a potential accidental loss of work as reported previously here:

https://bugs.kde.org/show_bug.cgi?id=389561

to reproduce: ...A simple way to reproduce is to do 4-5 strokes, undo some of them, toggle view of the layer, the redo history will be cleared and without showing any indication of any other step (as the view toggle doesn't gets recorded).

Video showing the issue: https://drive.google.com/file/d/1gQUo8KGpVjyExLIrbJGSRmLUGWT5a9tr/view?usp=sharing

Comment 1 Dmitry Kazakov 2018-04-02 15:14:45 UTC

Confirm

Comment 2 Dmitry Kazakov 2018-04-02 15:22:51 UTC

Git commit 515afb63df55cecc5aaa1e8f01618c306251b79f by Dmitry Kazakov.
Committed on 02/04/2018 at 15:22.
Pushed by dkazakov into branch 'master'.

Do not reset redo history when changing layer's visibility

M  +9    -1    libs/image/commands/kis_node_property_list_command.cpp

https://commits.kde.org/krita/515afb63df55cecc5aaa1e8f01618c306251b79f

Comment 3 Halla Rempt 2018-04-03 11:47:08 UTC

Git commit 8f6856236d549f50b70d337ed0aac0c00b5da194 by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 03/04/2018 at 11:21.
Pushed by rempt into branch 'krita/4.0'.

Do not reset redo history when changing layer's visibility
(cherry picked from commit 515afb63df55cecc5aaa1e8f01618c306251b79f)

M  +9    -1    libs/image/commands/kis_node_property_list_command.cpp

https://commits.kde.org/krita/8f6856236d549f50b70d337ed0aac0c00b5da194