Bug 390355

Summary:	crash when open Arabic xps file
Product:	[Applications] okular	Reporter:	Fahad Al-Saidi <Fahad.alsaidi>
Component:	XPS backend	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	oliver.sander
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/okular/42d4710198a76650ff2e117b5b1a966a3685f376	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	first example produced by scribus 5.4dev second example produced by MS office 2016

Description Fahad Al-Saidi 2018-02-13 06:17:20 UTC

Created attachment 110594 [details]
first example produced by scribus 5.4dev

Okular crashes when I try to open most of arabic xps files.

Comment 1 Fahad Al-Saidi 2018-02-13 06:18:03 UTC

Created attachment 110595 [details]
second example produced by MS office 2016

Comment 2 Oliver Sander 2018-02-13 08:53:25 UTC

Backtrace (first example file):

#0  0x00007fffce24cfc8 in readFileOrDirectoryParts (entry=0x0, pathOfFile=0x0)
    at /home/sander/okular-local-poppler/generators/xps/generator_xps.cpp:504
#1  0x00007fffce2545b9 in XpsPage::XpsPage (this=0x555555d957e0, file=0x555555d7c4d0, fileName=...)
    at /home/sander/okular-local-poppler/generators/xps/generator_xps.cpp:1389
#2  0x00007fffce259ac1 in XpsDocument::XpsDocument (this=0x555555d955b0, file=0x555555d7c4d0, fileName=...)
    at /home/sander/okular-local-poppler/generators/xps/generator_xps.cpp:1782
#3  0x00007fffce25b921 in XpsFile::loadDocument (this=0x555555d7c4d0, filename=...)
    at /home/sander/okular-local-poppler/generators/xps/generator_xps.cpp:1954
#4  0x00007fffce25cd03 in XpsGenerator::loadDocument (this=0x555555d866d0, fileName=..., pagesVector=...)
    at /home/sander/okular-local-poppler/generators/xps/generator_xps.cpp:2082
#5  0x00007fffd6cfa75f in Okular::Generator::loadDocumentWithPassword (this=0x555555d866d0, fileName=..., pagesVector=...)
    at /home/sander/okular-local-poppler/core/generator.cpp:212
#6  0x00007fffd6cb6c6e in Okular::DocumentPrivate::openDocumentInternal (this=0x5555558a1ba0, offer=..., isstdin=false, 
    docFile=..., filedata=..., password=...) at /home/sander/okular-local-poppler/core/document.cpp:872
#7  0x00007fffd6cbfb94 in Okular::Document::openDocument (this=0x5555558a6260, docFile=..., url=..., _mime=..., password=...)
    at /home/sander/okular-local-poppler/core/document.cpp:2355
#8  0x00007fffd704eb84 in Okular::Part::doOpenFile (this=0x555555876890, mimeA=..., fileNameToOpenA=..., 
    isCompressedFile=0x7fffffffd557) at /home/sander/okular-local-poppler/part.cpp:1383
#9  0x00007fffd704f8cd in Okular::Part::openFile (this=0x555555876890) at /home/sander/okular-local-poppler/part.cpp:1515
#10 0x00007ffff7b99336 in ?? () from /usr/lib/x86_64-linux-gnu/libKF5Parts.so.5
#11 0x00007ffff7b9a1c1 in KParts::ReadOnlyPart::openUrl(QUrl const&) () from /usr/lib/x86_64-linux-gnu/libKF5Parts.so.5
#12 0x00007fffd7050cf3 in Okular::Part::openUrl (this=0x555555876890, _url=..., swapInsteadOfOpening=false)
    at /home/sander/okular-local-poppler/part.cpp:1689
#13 0x00007fffd7050b4e in Okular::Part::openUrl (this=0x555555876890, url=...)
    at /home/sander/okular-local-poppler/part.cpp:1653
#14 0x0000555555567eb9 in Shell::openUrl (this=0x555555854b20, url=..., serializedOptions=...)
    at /home/sander/okular-local-poppler/shell/shell.cpp:280
#15 0x0000555555567993 in Shell::openDocument (this=0x555555854b20, url=..., serializedOptions=...)
    at /home/sander/okular-local-poppler/shell/shell.cpp:221
#16 0x0000555555564dc1 in Okular::main (paths=..., serializedOptions=...)
---Type <return> to continue, or q <return> to quit---
    at /home/sander/okular-local-poppler/shell/okular_main.cpp:170
#17 0x00005555555615ec in main (argc=2, argv=0x7fffffffdee8) at /home/sander/okular-local-poppler/shell/main.cpp:70

Comment 3 Albert Astals Cid 2018-02-14 00:41:40 UTC

Git commit 42d4710198a76650ff2e117b5b1a966a3685f376 by Albert Astals Cid.
Committed on 14/02/2018 at 00:40.
Pushed by aacid into branch 'Applications/17.12'.

XPS: Fix crash opening some files

Yet another QUrl porting mistake, i think this time is the correct one,
at least i can open all the 6 xps files i have

M  +1    -1    generators/xps/generator_xps.cpp

https://commits.kde.org/okular/42d4710198a76650ff2e117b5b1a966a3685f376