Bug 390351

Summary: Fix for the hang regressed horizontal scrollbar width
Product: [Frameworks and Libraries] frameworks-qqc2-desktop-style Reporter: Nate Graham <nate>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: normal CC: aleixpol, kde
Priority: NOR    
Version: 5.43.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 5.59
Sentry Crash Report:
Attachments: Scrollbar now too wide given amount of content

Description Nate Graham 2018-02-13 00:20:08 UTC
Created attachment 110588 [details]
Scrollbar now too wide given amount of content

You fixed the hang, for the good of humanity, yay!

Unfortunately the fix regressed the horizontal scrollbar, which is now too wide given the amount of content in the scrollview, compared to other scrollviews. See attached screen recording
Comment 1 Aleix Pol 2018-02-14 21:11:21 UTC
So it's a "legal" scrollbar with 0 as minimum and ~5 as maximum.

It's maybe breeze rendering it like that?
I agree the handle should be smaller.
Comment 2 Aleix Pol 2018-02-14 21:12:08 UTC
Just tested with QT_STYLE_OVERRIDE=oxygen and fusion. It looks about the same.
Comment 3 Aleix Pol 2019-05-10 14:57:31 UTC
https://phabricator.kde.org/D21131
Comment 4 Aleix Pol 2019-05-10 15:39:35 UTC
Git commit f7f99e8b8ca42c1036db4c25ce0488df2046b6a9 by Aleix Pol.
Committed on 10/05/2019 at 15:39.
Pushed by apol into branch 'master'.

ScrollBar: Make it work as a horizontal scroll bar as well

Summary:
It was only taking into account the height so always working as vertical.
This tracks the orientation property

Test Plan: Now case explained in the bug report works just fine, couldn't see any regressions.

Reviewers: #kirigami, mart, ngraham

Reviewed By: #kirigami, mart, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21131

M  +6    -3    org.kde.desktop/ScrollBar.qml

https://commits.kde.org/qqc2-desktop-style/f7f99e8b8ca42c1036db4c25ce0488df2046b6a9