| Summary: | Display "new screen connected" OSD when laptop Display key is pressed | ||
|---|---|---|---|
| Product: | [Plasma] KScreen | Reporter: | Andrew Crouthamel <andrew.crouthamel> |
| Component: | common | Assignee: | Sebastian Kügler <sebas> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, nate, plasma-bugs, stefan.bruens |
| Priority: | NOR | Keywords: | usability |
| Version: | 5.12.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kscreen/eacbddd22d990d4f434b8b9aaab865d5ac62a630 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | attachment-9450-0.html | ||
|
Description
Andrew Crouthamel
2018-02-08 19:36:22 UTC
See also the OSD that just went in https://phabricator.kde.org/D9414 It would be really nice to display that when the Display key is pressed. Good idea, I'll look into that. https://phabricator.kde.org/D10896 implements this. (In reply to Sebastian Kügler from comment #3) > https://phabricator.kde.org/D10896 implements this. That was fast! Tell me how to send you a beer! Testing out the revision on your own hardware and leaving a review comment would probably be the most productive course of action! ;) But I think all KDE developers should have a virtual "tip Jar". Would be a great way for other folks to show appreciation directly. @Andrew Email me for my physical address :) (A donation to KDE e.V. is always appreciated.) (In reply to Nate Graham from comment #5) > Testing out the revision on your own hardware and leaving a review comment > would probably be the most productive course of action! ;) What's the best way to test this since it will need to test my hardware key? Is there a good procedure for these sorts of things that need hardware access? I guess a Neon Dev Unstable USB stick? But, I'd need to patch this code in. If anyone could help me out with a test procedure, I'd be glad to try it. Run xev, press the display button, paste the output from xev here and I'll tell you if it'll work. (XF86Display is the key code you're looking for, CTRL+P should also work.) Alternatively, wait for the patch to land plus ~1 day and update from dev unstable packages or run the latest iso with those packages. (In reply to Sebastian Kügler from comment #8) > Run xev, press the display button, paste the output from xev here and I'll > tell you if it'll work. (XF86Display is the key code you're looking for, > CTRL+P should also work.) > > Alternatively, wait for the patch to land plus ~1 day and update from dev > unstable packages or run the latest iso with those packages. Here is the display key: KeyPress event, serial 40, synthetic NO, window 0x4800001, root 0x114, subw 0x0, time 542677, (661,760), root:(791,836), state 0x0, keycode 133 (keysym 0xffeb, Super_L), same_screen YES, XLookupString gives 0 bytes: XmbLookupString gives 0 bytes: XFilterEvent returns: False FocusOut event, serial 40, synthetic NO, window 0x4800001, mode NotifyGrab, detail NotifyAncestor FocusIn event, serial 40, synthetic NO, window 0x4800001, mode NotifyUngrab, detail NotifyAncestor KeymapNotify event, serial 40, synthetic NO, window 0x0, keys: 4294967261 0 0 0 2 0 0 0 0 0 0 0 0 0 0 0 32 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 KeyRelease event, serial 40, synthetic NO, window 0x4800001, root 0x114, subw 0x0, time 542744, (661,760), root:(791,836), state 0x40, keycode 33 (keysym 0x70, p), same_screen YES, XLookupString gives 1 bytes: (70) "p" XFilterEvent returns: False KeyRelease event, serial 40, synthetic NO, window 0x4800001, root 0x114, subw 0x0, time 542744, (661,760), root:(791,836), state 0x40, keycode 133 (keysym 0xffeb, Super_L), same_screen YES, XLookupString gives 0 bytes: XFilterEvent returns: False And here is Super+P (same shortcut) KeyPress event, serial 40, synthetic NO, window 0x4c00001, root 0x114, subw 0x0, time 754698, (2500,1125), root:(2630,1201), state 0x0, keycode 133 (keysym 0xffeb, Super_L), same_screen YES, XLookupString gives 0 bytes: XmbLookupString gives 0 bytes: XFilterEvent returns: False FocusOut event, serial 40, synthetic NO, window 0x4c00001, mode NotifyGrab, detail NotifyAncestor FocusIn event, serial 40, synthetic NO, window 0x4c00001, mode NotifyUngrab, detail NotifyAncestor KeymapNotify event, serial 40, synthetic NO, window 0x0, keys: 2 0 0 0 2 0 0 0 0 0 0 0 0 0 0 0 32 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 KeyRelease event, serial 40, synthetic NO, window 0x4c00001, root 0x114, subw 0x0, time 754843, (2500,1125), root:(2630,1201), state 0x40, keycode 33 (keysym 0x70, p), same_screen YES, XLookupString gives 1 bytes: (70) "p" XFilterEvent returns: False KeyRelease event, serial 40, synthetic NO, window 0x4c00001, root 0x114, subw 0x0, time 754959, (2500,1125), root:(2630,1201), state 0x40, keycode 133 (keysym 0xffeb, Super_L), same_screen YES, XLookupString gives 0 bytes: XFilterEvent returns: False Git commit eacbddd22d990d4f434b8b9aaab865d5ac62a630 by Sebastian Kügler. Committed on 01/03/2018 at 09:47. Pushed by sebas into branch 'master'. Show config selection OSD when display button is pressed Summary: This makes the working of the display button much more intuitive. Test Plan: Tested with external display plugged in, system behaves as expected Reviewers: #plasma, dvratil Reviewed By: dvratil Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D10896 M +3 -54 kded/daemon.cpp M +0 -4 kded/daemon.h https://commits.kde.org/kscreen/eacbddd22d990d4f434b8b9aaab865d5ac62a630 This should work. My own laptop has teh XF86Display keysym mapped, yours seems to have Super_L + p mapped (in both cases). Not long ago, to make work, we added a shortcut also for super+p to increase compatibility with Windowsy hardware (which seems to prefer super+p nowadays. In any case, if it doesn't work, you can always add a keymapping for XF86Display, but as I said, that shouldn't be necessary. Looks like it works in my Dev Unstable VM, the display button passes through. I'll test via USB stick tomorrow, but otherwise, this looks good! Created attachment 111208 [details] attachment-9450-0.html I tested this on real hardware (my XPS 13) and it works great! Thanks! --- Andrew Crouthamel On Thu, Mar 1, 2018 at 5:42 AM, Sebastian Kügler <bugzilla_noreply@kde.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=390096 > > --- Comment #11 from Sebastian Kügler <sebas@kde.org> --- > This should work. > > My own laptop has teh XF86Display keysym mapped, yours seems to have > Super_L + > p mapped (in both cases). Not long ago, to make work, we added a shortcut > also > for super+p to increase compatibility with Windowsy hardware (which seems > to > prefer super+p nowadays. In any case, if it doesn't work, you can always > add a > keymapping for XF86Display, but as I said, that shouldn't be necessary. > > -- > You are receiving this mail because: > You reported the bug. > |