Bug 390063

Summary:	Anazyler should be disabled when the Context View is disabled, instead keeps running
Product:	[Applications] amarok	Reporter:	ThomasvonderElbe
Component:	Context View/Spectrum Analyzer	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	TheCrasher
Priority:	NOR
Version:	2.8.0
Target Milestone:	2.9
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/multimedia/amarok/-/commit/6b10f5d938634570dc3cc11ce308e82ae9a5e019	Version Fixed In:
Sentry Crash Report:

Description ThomasvonderElbe 2018-02-08 08:57:33 UTC

After a fresh amarok install: If you just close the context view (and therefore the analyzer with it) the analyzer somehow runs in the back using precious cpu-ressources even if amarok is completely idle and minimized. (In my case with a 4GH CPU it is 2%) ... Imagine how many people use it ... and how this sums up over time. Not good for mother Earth.

Workaround: Close the analyzer first, then close the context view.

Please change this! 
And many thanks for the wonderful player!

Comment 1 Myriam Schweingruber 2018-02-08 09:16:45 UTC

Not a bug, and something you can change easily. Amaroks Context View is a feature, not a bug.

Comment 2 ThomasvonderElbe 2018-02-08 10:10:52 UTC

I think you misunderstood me.
Of course is the Context View a feature!
The bug is the following: If you close Context View ... the analyzer is still running.

Comment 3 Myriam Schweingruber 2018-02-17 23:25:48 UTC

Right, changing description of the bug, then, as the initial one is not really clear.

Comment 4 ThomasvonderElbe 2018-02-18 08:32:27 UTC

Thank you for reopening the bug!

And thank you for improving the description of the bug! It's clearer now.

Now one question remains for me: Now that we agree, that the Analyzer should be disabled when the Context View is disabled .... shouldn't the Analyzer also pause, when Amarok is idle and minimized? 

Why waste precious resources in this case?

Should I open an additional bug report for this?

Comment 5 Bug Janitor Service 2024-05-19 19:53:41 UTC

A possibly relevant merge request was started @ https://invent.kde.org/multimedia/amarok/-/merge_requests/98

Comment 6 Tuomas Nurmi 2024-05-22 17:50:07 UTC

Git commit 6b10f5d938634570dc3cc11ce308e82ae9a5e019 by Tuomas Nurmi.
Committed on 22/05/2024 at 17:33.
Pushed by nurmi into branch 'master'.

Don't feed analyzer new data if it is minimized or hidden

M  +1    -0    ChangeLog
M  +1    -0    src/MainWindow.h
M  +7    -1    src/context/applets/analyzer/plugin/AnalyzerBase.cpp
M  +4    -1    src/context/applets/analyzer/plugin/AnalyzerBase.h
M  +4    -0    src/context/applets/analyzer/plugin/BlockAnalyzer.cpp

https://invent.kde.org/multimedia/amarok/-/commit/6b10f5d938634570dc3cc11ce308e82ae9a5e019

Comment 7 ThomasvonderElbe 2024-05-22 18:01:36 UTC

Thank you! Wonderful! :-)