Bug 389921

Summary:	Spreadsheet column names only saved if you hit Enter
Product:	[Applications] LabPlot2	Reporter:	Matthew Trescott <matthewtrescott>
Component:	frontend	Assignee:	Alexander Semke <alexander.semke>
Status:	RESOLVED FIXED
Severity:	normal	CC:	urcindalo
Priority:	NOR
Version:	latest
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://commits.kde.org/labplot/ae9b9b68fa49ae6b2eb9f7f1ac6944ac15e75549	Version Fixed In:	2.5

Description Matthew Trescott 2018-02-05 16:48:59 UTC

Title pretty much says it all. It's possible to set column names in a Spreadsheet, but only if you hit Enter on your keyboard after typing the name. Otherwise, the name you type does not appear on the spreadsheet and disappears when you select something else.

Comment 1 Matthew Trescott 2018-02-05 16:50:13 UTC

Same goes for the "Comment" field in the column settings.

Comment 2 Matthew Trescott 2018-02-05 18:00:55 UTC

Same with axis start/end settings for x-y plots. That was the source of much confusion with #389855.

Comment 3 Matthew Trescott 2018-02-05 22:12:03 UTC

Same with x-Range/y-Range for plots.

Comment 4 urcindalo 2018-04-17 08:30:55 UTC

Same here.

Comment 5 Alexander Semke 2018-04-30 08:20:26 UTC

Git commit ae9b9b68fa49ae6b2eb9f7f1ac6944ac15e75549 by Alexander Semke.
Committed on 30/04/2018 at 08:18.
Pushed by asemke into branch 'master'.

Immediately accept text changed for name and comment fields in the dock widgets instead of accepting them after return was pressed.
FIXED-IN: 2.5

M  +2    -2    src/kdefrontend/dockwidgets/AxisDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/CantorWorksheetDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/CartesianPlotDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/CartesianPlotLegendDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/ColumnDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/CustomPointDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/HistogramDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/MatrixDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/NoteDock.cpp
M  +1    -1    src/kdefrontend/dockwidgets/SpreadsheetDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/WorksheetDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/XYCurveDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/XYDataReductionCurveDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/XYDifferentiationCurveDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/XYEquationCurveDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/XYFitCurveDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/XYFourierFilterCurveDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/XYFourierTransformCurveDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/XYIntegrationCurveDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/XYInterpolationCurveDock.cpp
M  +2    -2    src/kdefrontend/dockwidgets/XYSmoothCurveDock.cpp
M  +2    -2    src/kdefrontend/widgets/DatapickerCurveWidget.cpp
M  +2    -2    src/kdefrontend/widgets/DatapickerImageWidget.cpp

https://commits.kde.org/labplot/ae9b9b68fa49ae6b2eb9f7f1ac6944ac15e75549

Comment 6 Alexander Semke 2018-04-30 08:24:29 UTC

(In reply to Matthew Trescott from comment #2)
> Same with axis start/end settings for x-y plots. That was the source of much
> confusion with #389855.
I changed the behavior now for name and comment text fields - changes will be accepted immediately. At the moment this produces to many entries in the history (undo/redo) stack and we need to merge the changes. This together with the similar change for other input text fields like for ranges etc. will be addressed soon, too.