| Summary: | DeInterlacing is enabled by default on HD channels and it is very slow | ||
|---|---|---|---|
| Product: | [Applications] kaffeine | Reporter: | Valentin Zagura <puthre> |
| Component: | general | Assignee: | Mauro Carvalho Chehab <mchehab> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gerhard.arnold, lukaszbatek |
| Priority: | NOR | ||
| Version First Reported In: | 2.0.13 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Valentin Zagura
2018-02-02 00:09:44 UTC
(In reply to Valentin Zagura from comment #0) > I spent a few hours investigating the very low framerate of HD channels in > Kaffeine until I've found out that deinterlacing was enabled by default. > I don't think the deinterlacing should be enabled by default, especially on > HD channels. Not sure how to fix it. Kaffeine doesn't know if the hardware is fast enough for de-interlacing a certain video. Depending on the GPU, de-interlacing can happen inside it. In other words, the entire de-interlacing and GPU performance is handled by libVLC. After thinking about that, I ended by adding this patch: https://commits.kde.org/kaffeine/73307da9a81bebbfae745e715c097104914963fc It improves de-interlacing selection and sets default to not interlace: Git commit 73307da9a81bebbfae745e715c097104914963fc by Mauro Carvalho Chehab. Committed on 20/02/2018 at 17:58. Pushed by mauroc into branch 'master'. mediawidget: allow better control of deinterlacing mode Instead of just on/off, allow setting the de-interlacing mode to the types supported by libVLC. Also changes default to not do deinterlacing, as most TV programs nowadays are in progressive mode, and doing de-interlacing on 4K programs can be a very CPU intensive task. Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> M +1 -1 doc/index.docbook M +2 -2 src/abstractmediawidget.h M +3 -6 src/backend-mplayer/mplayermediawidget.cpp M +2 -2 src/backend-mplayer/mplayermediawidget.h M +36 -5 src/backend-vlc/vlcmediawidget.cpp M +1 -1 src/backend-vlc/vlcmediawidget.h M +135 -28 src/mediawidget.cpp M +17 -2 src/mediawidget.h *** Bug 387750 has been marked as a duplicate of this bug. *** *** Bug 397532 has been marked as a duplicate of this bug. *** |