Bug 389759

Summary: Fix : Start/Stop text doesn't update on click
Product: [Applications] kmag Reporter: kndevl
Component: generalAssignee: sarang
Status: RESOLVED FIXED    
Severity: normal CC: kinofhek
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: patch to fix this issue

Description kndevl 2018-02-01 17:59:17 UTC
Created attachment 110291 [details]
patch to fix this issue

The Start/Stop action doesn't update text when clicked.

When `setText` method is initially called through the class constructor, it also sets `IconText` property. Now, further calls to `setText` doesn't change `IconText` property and hence the "start" / "stop" text changes are not reflected in the UI.

Here is a snippet from the doc.

> If the icon text is not explicitly set, the action's normal text will be used > for the icon text.

> If the text is not explicitly set in the constructor, or by using setText(), > the action's description icon text will be used as text. There is no default > text.
Comment 1 kndevl 2018-02-01 18:04:00 UTC
I have also created a diff on Phabricator at https://phabricator.kde.org/D10238
Comment 2 Felipe Kinoshita 2021-06-18 07:52:38 UTC
Not happening for me on 20.12.1, can someone confirm?
Comment 3 kndevl 2021-06-19 19:34:59 UTC
I tested 21.04.2-1 and I don't notice the bug.