Summary: | Date edit should default on day section | ||
---|---|---|---|
Product: | [Applications] kmymoney | Reporter: | Anguo <kde_bugs> |
Component: | general | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | flywire0, ralf.habacker |
Priority: | NOR | ||
Version: | 4.8.1 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=374123 | ||
Latest Commit: | https://commits.kde.org/kmymoney/904775b2005c888abaf869b70ab8c46f0e1e5074 | Version Fixed In: | 4.8.2 |
Description
Anguo
2018-01-30 06:58:52 UTC
Looks like we need to introduce a new user option for data entry here as both requests exclude each other. Regarding your question "Also, since we're speaking about the date selection widget, what I'd really like is to be able to move to the next month/year simply by incrementing the day part" I found the following in our very fine documentation at https://docs.kde.org/stable4/en/extragear-office/kmymoney/reference.widgets.html#reference.widgets.datepicker : "Within the date entry widget, the left/right cursor keys can be used to switch between the day, the month, and the year fields. Using the up/down cursor keys, the value of the selected field can be incremented/decremented. The + and - keys can be used to increment/decrement a single day. Month and year boundaries are considered and incremented/decremented if necessary. Pressing T will set the date to today's date." And that +/- day inc/dec function even works if the cursor is in the year field. Maybe, that is already the function you are looking for. Thank you Thomas. I feel your pain, when, as a developer, you face two end users with mutually exclusive requests. I am grateful for your long term contributions to this project. The +/- keys cover perfectly the second need I was describing. Thanks a lot. Next time, I'll make sure to consult the kmymoney documentation first. Sorry about that. Back to the original request about the focus on the day section of the date widget: Personally, I am fortunate enough to be using Gentoo, so having managed to find the appropriate commit (referred above), it was easy enough to produce a quick and dirty patch and re-emerge (re-compile) the package, so that on my system the focus is now back on the day section. But it helps only me and potentially other Gentoo/kmymoney users. The +/- key functionally render the feature request less important because other users may form the habit of using the +/- keys instead of the arrows. Having said that, I still prefer using the arrows, because when I key in my transactions, my fingers are already placed there (due to selecting the payee a couple of fields earlier), so I will keep my patch in place. Besides, I can't really think of a use case where focus on the year section in the widget might be more useful in a day to day use of kmymoney... It really appears to me more logical to have the default focus placed on the day, regardless of the date format used, as it used to be. Please do not feel undue pressure for what is now a minor request, but for the record, the ideal functionality would be if the arrow up/down keys would behave as the +/- keys, i.e. if they were also incrementing/descrementing the month and year when appropriate. Then we can ignore the end of month situation and always use the same arrow keys. I am not familiar with the QT API so I don't know how much of a hassle it would be to implement. Feel free to ignore this. void KMyMoney::OldDateEdit::keyPressEvent(QKeyEvent* k) { // ... QDateEdit::keyPressEvent(k); } http://doc.qt.io/archives/qt-4.8/qdatetimeedit.html#keyPressEvent See also https://bugs.kde.org/show_bug.cgi?id=355010 - Autofill Transaction Select Amount The related review request is https://phabricator.kde.org/D10310 Git commit 904775b2005c888abaf869b70ab8c46f0e1e5074 by Ralf Habacker. Committed on 06/02/2018 at 20:06. Pushed by habacker into branch '4.8'. Allow the user to select the initial date cursor position in the settings dialog As default the cursor position is set to the day part of the date field. This patch contains a fix to be compilable with gcc 4.8. Related: bug 374123 FIXED-IN:4.8.2 Test Plan: compiled and tested on linux Reviewers: #kmymoney, tbaumgart Reviewed By: #kmymoney, tbaumgart Subscribers: tbaumgart Differential Revision: https://phabricator.kde.org/D10310 M +46 -0 kmymoney/dialogs/settings/ksettingsregisterdecl.ui M +9 -0 kmymoney/settings/kmymoney.kcfg M +1 -0 kmymoney/settings/kmymoneysettings.kcfgc M +12 -4 kmymoney/widgets/kmymoneydateinput.cpp https://commits.kde.org/kmymoney/904775b2005c888abaf869b70ab8c46f0e1e5074 Git commit e0e1604642ac5245d232349f7a5cf203652075af by Ralf Habacker. Committed on 06/02/2018 at 20:05. Pushed by habacker into branch '4.8'. Fix issues with multiple instances of KMyMoneySettings Calling a static method from class KMyMoneyGlobalSettings inside kmm_widgets library surprisingly creates an additional KMymoneySettings instance, which does not reflect the recent state from the setting dialog. The reason for this behavior is caused by duplicated implementations of class KMymoneySettings (kmm_config, settings) and embedding the static library kmm_config into shared libraries (kmm_mymoney, kmm_widgets and kmm_ofximport). Each embedded copy has it's own instance of class KMymoneySettings. The solution for this issue, which is done with this patch, is to remove the duplicated implementation from the settings library and to make kmm_config a shared library. This patch also renames kmm_config to kmm_settings and place it into it own subdirectory to keep in sync with 5.0 branch. Related: bug 374123 FIXED-IN:4.8.2 Test Plan: compiled on linux Reviewers: #kmymoney, tbaumgart Reviewed By: tbaumgart Subscribers: tbaumgart Differential Revision: https://phabricator.kde.org/D10322 M +10 -10 kmymoney/CMakeLists.txt M +1 -1 kmymoney/converter/CMakeLists.txt M +1 -8 kmymoney/dialogs/settings/CMakeLists.txt M +1 -1 kmymoney/models/CMakeLists.txt M +1 -1 kmymoney/mymoney/CMakeLists.txt M +1 -1 kmymoney/plugins/onlinetasks/sepa/CMakeLists.txt M +5 -5 kmymoney/reports/CMakeLists.txt A +13 -0 kmymoney/settings/CMakeLists.txt R +0 -0 kmymoney/settings/kmymoney.kcfg [from: kmymoney/kmymoney.kcfg - 100% similarity] R +2 -0 kmymoney/settings/kmymoneysettings.kcfgc [from: kmymoney/kmymoneysettings.kcfgc - 053% similarity] M +4 -4 kmymoney/widgets/CMakeLists.txt https://commits.kde.org/kmymoney/e0e1604642ac5245d232349f7a5cf203652075af |