Bug 389614

Summary:	Make "Save As..." the default save option in the Save split button
Product:	[Applications] Spectacle	Reporter:	Nate Graham <nate>
Component:	General	Assignee:	Boudhayan Gupta <me>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	aotto1968, bugseforuns
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://commits.kde.org/spectacle/9930b493e14da807974c7607f463ecc5e0eb9e31	Version Fixed/Implemented In:
Sentry Crash Report:

Description Nate Graham 2018-01-29 20:28:20 UTC

Lots of people online complain that it's too hard to find the Save As... option in spectacle, including a high-profile reviewer who checked out Plasma 5.12: http://www.ocsmag.com/2018/01/27/plasma-5-12-long-term-sweetness/

"Then, it’s also somewhat clunky setting up the Save As options rather than Save & Exit."

In the medium term, I plan to re-do the bottom button UI to stop using a split button, but in the meantime, I propose we make Save As... the default option for the Save split button. If you want to quit after saving... you can just quit, or change the save type to "Save & Exit"

Comment 1 Christoph Feck 2018-01-31 03:47:41 UTC

*** Bug 389074 has been marked as a duplicate of this bug. ***

Comment 2 Nate Graham 2018-01-31 05:16:15 UTC

I've submitted a patch for this: https://phabricator.kde.org/D10198

Comment 3 Nate Graham 2018-01-31 14:00:50 UTC

Git commit 9930b493e14da807974c7607f463ecc5e0eb9e31 by Nathaniel Graham.
Committed on 31/01/2018 at 14:00.
Pushed by ngraham into branch 'master'.

Make "Save As" the default save mode

Summary:

Yet more anecdotal evidence from bug triaging suggests that many would prefer "Save As" to be the default save mode in Spectacle. This patch accomplishes that.

I am planning a larger rewrite of the buttons sometime in the coming weeks that should hopefully end squabbles over button settings, but until then, I believe this will be a welcome improvement.

Test Plan:
Tested in KDE Neon
- Removed ~/.config/spectaclerc; "Save As" is now the default save mode
- Clicked "Save As" button: correct save operation is performed; button stays in "Save As" mode
- Changed the button to other save modes; same thing
- Quit Spectacle and re-opened when the button was in each save mode; it opened in the correct mode

{F5684691}

Reviewers: #spectacle, rkflx, rkron

Reviewed By: rkron

Differential Revision: https://phabricator.kde.org/D10198

M  +8    -8    src/Gui/KSMainWindow.cpp

https://commits.kde.org/spectacle/9930b493e14da807974c7607f463ecc5e0eb9e31