| Summary: | Adjust the size of settings window to eliminate the scroll bar or remember the window size after manual resizing | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Patrick Silva <bugseforuns> |
| Component: | panels: information | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | meven29, nate |
| Priority: | NOR | Keywords: | junior-jobs, usability |
| Version: | 18.12.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/ecf1ae6d0b1691bfe36fc0ff64500f111f3abc32 | Version Fixed In: | 19.08 |
| Sentry Crash Report: | |||
| Attachments: | demonstration | ||
Good catch. This is in baloo-widgets::FileMetadataWidget::sizeHint(). There's some unnecessarily complicated calculation to determine the size that appears to return the wrong value. If I can figure out what's going on, it should be a pretty trivial patch. I believe the issue is in baloo-widgets::FileMetaDataConfigWidget::sizeHint(). I am trying to produce a patch. Sweet, awesome! Should it be a fixed height ? Or should we take into account the number of lines, and their height ? In which it will require some refactoring as the current implementation does allow the access the number of lines of the widget when sizeHint is called. QML could be nice here I guess, but for this would require more refactoring... Optimally, I think the height should match the list size up until it would exceed, say, 2/3 of the screen height. At that point, the height no longer increases and it becomes scrollable. The problem here is that the config dialog appears before the metadata is loaded. it requires some refactoring. I have a half working set of patch. I would be curious to find an example of a dialog with similar behavior : loads data and then is shown adapting its height to the data. I also wonder how to properly sizeHint the widget, since I can know how many lines to show, but how height should a line be ? Git commit c36d6b26eb3f9817342b3af5ad1c0a59672d11bf by Stefan Brüns. Committed on 22/04/2019 at 11:24. Pushed by bruns into branch 'master'. [FileMetaDataWidget] Allow inline configuration of visible properties Summary: Instead of opening an additional dialog, allow selection and deselection of visible properties directly in the widget. Reviewers: #baloo, #dolphin, #frameworks, ngraham, astippich, elvisangelaccio Reviewed By: #baloo, #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio Tags: #baloo Differential Revision: https://phabricator.kde.org/D20524 M +91 -6 src/filemetadatawidget.cpp M +16 -0 src/filemetadatawidget.h https://commits.kde.org/baloo-widgets/c36d6b26eb3f9817342b3af5ad1c0a59672d11bf The information panel metadata config dialog is gone and has been replaced by inline setting editing by : https://phabricator.kde.org/D20524 making this bug irrelevant in the first place. The new inlined setting editing does not suffer from the same limited number of column displayed. Instead it uses the available size of the information panel metadata. Git commit ecf1ae6d0b1691bfe36fc0ff64500f111f3abc32 by Stefan Brüns. Committed on 23/04/2019 at 10:36. Pushed by bruns into branch 'master'. [InformationPanel] Use the new inline configuration mode Summary: The current external configuration dialog has some issues: - its layout is suboptimal, as its initial size is typically to small - it is quite disassociated with the actual widget it configures, properties have a different order, and the property names can be quite abstract without the corresponding value. Doing the visibility selection inline typically avoids the sizing problem, as the containing application (dolphin) is often vertically maximized. The selection becomes more obvious, as the item order is kept, and the values are shown. Depends on D20524 Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20525 M +1 -1 CMakeLists.txt M +0 -1 src/CMakeLists.txt D +0 -102 src/panels/information/filemetadataconfigurationdialog.cpp D +0 -72 src/panels/information/filemetadataconfigurationdialog.h M +6 -8 src/panels/information/informationpanel.cpp M +1 -0 src/panels/information/informationpanel.h M +33 -0 src/panels/information/informationpanelcontent.cpp M +9 -0 src/panels/information/informationpanelcontent.h https://commits.kde.org/dolphin/ecf1ae6d0b1691bfe36fc0ff64500f111f3abc32 |
Created attachment 110186 [details] demonstration Every time I open info panel settings I need to scroll or manually resize the window to show the options on bottom. I think would be nice if the window size is enough to eliminate the scroll bar or the window size is remembered after manual resizing at least.