| Summary: | Side margins too large in Comments/Reviews overlay | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Andres Betts <anditosan1000> |
| Component: | discover | Assignee: | Aleix Pol <aleixpol> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/discover/3bbe138d504c38e80330dd4b41a6ef61948d0a01 | Version Fixed In: | 5.12 |
| Attachments: |
MarginsTooBig
Doesn't help enough. |
||
Should be improved by c9b59ebfb8585d930d005f4545d7ec6d61680bfb in 5.12 Created attachment 110224 [details]
Doesn't help enough.
Doesn't help enough in the mobile view. See attachment.
Git commit 3bbe138d504c38e80330dd4b41a6ef61948d0a01 by Aleix Pol. Committed on 30/01/2018 at 15:06. Pushed by apol into branch 'Plasma/5.12'. Improve the ReviewsPage look Just add the necessary margin on the view. Also let it show it's a sheet when displaying the margin instead of just showing blank space on wide mode. M +1 -0 discover/qml/ApplicationPage.qml M +3 -0 discover/qml/ReviewsPage.qml https://commits.kde.org/discover/3bbe138d504c38e80330dd4b41a6ef61948d0a01 There we go, much better!! |
Created attachment 110165 [details] MarginsTooBig It seems that the margins for application comments are hard set, we may need to allow them to use more room or more consistent with the spacing for the app details. The attached image shows margins are too big for the reviews page.