Bug 389517

Summary:	Audio files cant be played after restart
Product:	[Applications] parley	Reporter:	Holger Götz <goetz>
Component:	general	Assignee:	parley bug tracker <parley-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hartmut.riesenbeck
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	https://commits.kde.org/libkeduvocdocument/ce08ff30dfa512c4bd613181a12e26a1670f3fa3	Version Fixed In:
Sentry Crash Report:

Description Holger Götz 2018-01-27 16:18:18 UTC

Hi,

I am using parley to learn Swedish vocabulary.

After assigning a sound file to an entry the sound plays as expected. After the restart of parley then only the relative part (compared to the .kvtml) of the sound-file is still present. This leads to the problem that the sound file can not be played.
Though as relative path saving makes sense, I guess the problem is more with the playing part.

I use parley version 2.10

Comment 1 Hartmut Riesenbeck 2018-02-04 20:08:41 UTC

Hello Holger

I can confirm the bug. After a first look to the source code, it looks like the problem is in libkeduvocdocument. I tested sound playing in KWordQuiz too and it shows the same failure. This strengthens my guess.

I will try to fix it.

Comment 2 Hartmut Riesenbeck 2018-11-03 19:59:27 UTC

Git commit ce08ff30dfa512c4bd613181a12e26a1670f3fa3 by Hartmut Riesenbeck.
Committed on 03/11/2018 at 19:58.
Pushed by hriesenbeck into branch 'master'.

Fix parsing of sound and image urls with relative paths

Summary:
Relative file paths for sound and image files were not correctly parsed
into QUrl objects. The reason for this is, that the previous used
QUrl::isRelative() does not work as its name lets suppose. So the
relative file path detection is changed to QDir methods.

Unit tests for sound and image file path parsing were added.

Test Plan: Run unit tests

Reviewers: #kde_edu, whiting, tcanabrava

Reviewed By: #kde_edu, tcanabrava

Subscribers: kde-edu

Tags: #kde_edu

Differential Revision: https://phabricator.kde.org/D10370

A  +3    -0    .arcconfig
M  +166  -1    keduvocdocument/autotests/readerkvtml2test.cpp
M  +11   -8    keduvocdocument/readerwriters/keduvockvtml2reader.cpp

https://commits.kde.org/libkeduvocdocument/ce08ff30dfa512c4bd613181a12e26a1670f3fa3