| Summary: | Font is always bold when model is opened, although default font is regular style | ||
|---|---|---|---|
| Product: | [Applications] umbrello | Reporter: | Robert Hairgrove <code> |
| Component: | general | Assignee: | Umbrello Development Group <umbrello-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | ||
| Priority: | NOR | ||
| Version: | 2.23.3 (KDE Applications 17.08.3) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/umbrello/1a3a5424fa2ee8613797dcc6238a54136e10ea9e | Version Fixed In: | 2.24.3 (KDE Applications 17.12.3) |
|
Description
Robert Hairgrove
2018-01-24 00:05:20 UTC
I realize that the convention is to show class names in boldface, and if a class or method is abstract, then it is shown in italics. So Umbrello probably overrides the font style for these things. However, then it should do this consistently and not set things to regular font style when they *should* be bold, etc. Git commit 34dc002381252db1f4e7c4cce0ef50131b0663f5 by Ralf Habacker. Committed on 27/01/2018 at 14:40. Pushed by habacker into branch 'Applications/17.12'. Fix 'Font is always bold when model is opened, although default font is regular style' Umbrello modifies font style to indicate specific class/member attribute states, so we need to disable any font style preferences. Because QFontDialog does not support disabling font style list, it is required to fall back to KFontChooser for the KF5 variant. FIXED-IN:2.24.2 (KDE Applications 17.12.2) M +1 -0 umbrello/dialogs/multipagedialogbase.cpp M +1 -14 umbrello/dialogs/settingsdialog.cpp M +1 -5 umbrello/dialogs/settingsdialog.h M +1 -15 umbrello/dialogs/umlviewdialog.cpp M +0 -4 umbrello/dialogs/umlviewdialog.h https://commits.kde.org/umbrello/34dc002381252db1f4e7c4cce0ef50131b0663f5 Git commit 149407314e7cc360de6fdf312ae434c5da83df18 by Ralf Habacker. Committed on 17/02/2018 at 13:02. Pushed by habacker into branch 'Applications/17.12'. Refactoring of global variables used by class CombinedFragmentWidget - use defaultMargin from UMLWidget instead local copy - move only locally used constants into implementation - convert constants to a const int type M +27 -23 umbrello/umlwidgets/combinedfragmentwidget.cpp M +0 -4 umbrello/umlwidgets/combinedfragmentwidget.h https://commits.kde.org/umbrello/149407314e7cc360de6fdf312ae434c5da83df18 Git commit 1a3a5424fa2ee8613797dcc6238a54136e10ea9e by Ralf Habacker. Committed on 18/02/2018 at 11:45. Pushed by habacker into branch 'Applications/17.12'. Fix 'Box widgets inside a combined fragment are not selectable' The fix is implemented by adding a virtual method shape(), which returns a tube around the widget border. The bounding rect of the widget has been adjusted to reflect the shape. FIXED-IN:2.24.3 (KDE Applications 17.12.3) M +50 -5 umbrello/umlwidgets/combinedfragmentwidget.cpp M +4 -1 umbrello/umlwidgets/combinedfragmentwidget.h M +4 -1 umbrello/umlwidgets/umlwidget.cpp M +2 -0 umbrello/umlwidgets/umlwidget.h https://commits.kde.org/umbrello/1a3a5424fa2ee8613797dcc6238a54136e10ea9e Git commit 1ee663309689dca20f8bd593ec2fcc8e74145bb5 by Ralf Habacker. Committed on 21/02/2018 at 07:49. Pushed by habacker into branch 'Applications/17.12'. Increase shape part for resize marker to make it easier to select in low zoom levels M +1 -1 umbrello/umlwidgets/combinedfragmentwidget.cpp https://commits.kde.org/umbrello/1ee663309689dca20f8bd593ec2fcc8e74145bb5 Git commit 0cdd90dd513d35c45386b5739b36610d5b2b4c6c by Ralf Habacker. Committed on 21/02/2018 at 07:47. Pushed by habacker into branch 'Applications/17.12'. Fixup shape for alternate combined fragment widget M +11 -2 umbrello/umlwidgets/combinedfragmentwidget.cpp https://commits.kde.org/umbrello/0cdd90dd513d35c45386b5739b36610d5b2b4c6c |