| Summary: | Track Sorting | ||
|---|---|---|---|
| Product: | [Applications] juk | Reporter: | tywigi |
| Component: | general | Assignee: | Kacper Kasper <kacperkasper> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kacperkasper, mpyne |
| Priority: | NOR | ||
| Version First Reported In: | 17.12.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/juk/cd8e92003e0bf4806af3d8bb8d7a1fba7ea5cdb7 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
tywigi
2018-01-17 20:33:29 UTC
I have local changes that fix this. Git commit 81c0dcc278a9c17fb96e0b41ab34bc32fb2c289e by Kacper Kasper. Committed on 28/01/2018 at 14:13. Pushed by kkasper into branch 'master'. Fix columns sorting. Summary: QTreeWidgetItem in Qt5 requires overloading < operator to implement custom sorting. Use existing compare methods to do that. Additionally, natural sorting was implemented for strings. This allows to sort by filenames like file_<number>. Test Plan: Click on columns to sort them. Columns are sorted by artist, album and track number. Reviewers: mpyne Differential Revision: https://phabricator.kde.org/D10130 M +24 -8 playlistitem.cpp M +3 -1 playlistitem.h https://commits.kde.org/juk/81c0dcc278a9c17fb96e0b41ab34bc32fb2c289e Git commit cd8e92003e0bf4806af3d8bb8d7a1fba7ea5cdb7 by Michael Pyne, on behalf of Kacper Kasper. Committed on 10/02/2018 at 22:47. Pushed by mpyne into branch 'Applications/17.12'. Fix columns sorting. Summary: QTreeWidgetItem in Qt5 requires overloading < operator to implement custom sorting. Use existing compare methods to do that. Additionally, natural sorting was implemented for strings. This allows to sort by filenames like file_<number>. Test Plan: Click on columns to sort them. Columns are sorted by artist, album and track number. Reviewers: mpyne Differential Revision: https://phabricator.kde.org/D10130 M +24 -8 playlistitem.cpp M +3 -1 playlistitem.h https://commits.kde.org/juk/cd8e92003e0bf4806af3d8bb8d7a1fba7ea5cdb7 |